1216260 - Remove usage of mozMatchesSelector from Add-on SDK codebase

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Mike Taylor [:miketaylr]]

And use Element.matches() instead.

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: Bug-1216260.-Replace-mozMatchesSelector-with-matches.patch

Heya Jordan, would you mind reviewing?

Comment 2

[Mike Taylor [:miketaylr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7abe93553eb6

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8675852 [details] [diff] [review]
Bug-1216260.-Replace-mozMatchesSelector-with-matches.patch

Review of attachment 8675852 [details] [diff] [review]:
-----------------------------------------------------------------

Passing this to matteo, he's more familiar with the context menu code!

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8675852 [details] [diff] [review]
Bug-1216260.-Replace-mozMatchesSelector-with-matches.patch

Review of attachment 8675852 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 5

[Mike Taylor [:miketaylr]]

Attachment: 1216260.-Replace-mozMatchesSelector-with-matches.patch

Thanks for the review!

Updating commit message to reflect r=matteo and carrying forward r+.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ec162b01828a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec162b01828a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ec162b01828a

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion