Closed Bug 1216269 Opened 9 years ago Closed 9 years ago

tab-firefox.js typo in tab attach method

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jlong, Unassigned)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Starting on line 214, in the `attach` method of the tab, there is this code:

      let listener = (frame) => {
        if (frame.frameElement != browser(this))
          return;

        listener.off("attach", listener);
        attach(frame);
      };
      frames.on("attach", listener);


The `listener.off` line is wrong, it should be `frames.off`. One of our tests is failing but the error is being swallowed by promises so we haven't noticed. (We don't use this much in tests, as far as I know there is only 1 tests that uses this method).
Summary: tab-firefox.js type in tab attach method → tab-firefox.js typo in tab attach method
Attached patch 1216269.patch (obsolete) — Splinter Review
Attachment #8675855 - Flags: review?(zer0)
Blocks: 1200798
Comment on attachment 8675855 [details] [diff] [review]
1216269.patch

Review of attachment 8675855 [details] [diff] [review]:
-----------------------------------------------------------------

We should have a test that cover this scenario; however is not a blocker to land this fix.
Attachment #8675855 - Flags: review?(zer0) → review+
Attached patch 1216269.patchSplinter Review
added r=zer0 to the commit
Attachment #8675855 - Attachment is obsolete: true
Those errors have to be unrelated.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dc2bae25030b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.