1216269 - tab-firefox.js typo in tab attach method

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[James Long (:jlongster)]

Starting on line 214, in the `attach` method of the tab, there is this code:

      let listener = (frame) => {
        if (frame.frameElement != browser(this))
          return;

        listener.off("attach", listener);
        attach(frame);
      };
      frames.on("attach", listener);


The `listener.off` line is wrong, it should be `frames.off`. One of our tests is failing but the error is being swallowed by promises so we haven't noticed. (We don't use this much in tests, as far as I know there is only 1 tests that uses this method).

Comment 1

[James Long (:jlongster)]

Fixed in https://github.com/mozilla/addon-sdk/pull/2037

Comment 2

[James Long (:jlongster)]

Attachment: 1216269.patch

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8675855 [details] [diff] [review]
1216269.patch

Review of attachment 8675855 [details] [diff] [review]:
-----------------------------------------------------------------

We should have a test that cover this scenario; however is not a blocker to land this fix.

Comment 4

[James Long (:jlongster)]

Attachment: 1216269.patch

added r=zer0 to the commit

Comment 5

[James Long (:jlongster)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66fc9c7010cd

Comment 6

[James Long (:jlongster)]

Previous try is borked. New one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde5165ef84e

Comment 7

[James Long (:jlongster)]

Those errors have to be unrelated.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dc2bae25030b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc2bae25030b