Tooltips don't open if they don't immediately vertically fit on the screen

RESOLVED FIXED in Firefox 45, Firefox OS v2.5

Status

()

Core
XUL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aleth, Assigned: nicko.robson)

Tracking

({regression})

Trunk
mozilla45
regression
Points:
---

Firefox Tracking Flags

(firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

2 years ago
STR
Put the contact window in the bottom right corner of the screen, and hover over contact.
The tooltip only shows once its initial size doesn't fit on the screen, vertically at least. (Once it's shown, it can grow successfully.)
(Reporter)

Comment 1

2 years ago
Doesn't just happen in the contact window of course. Likely a m-c regression.
Keywords: regression
Whiteboard: [1.6-blocking]
(Reporter)

Comment 2

2 years ago
(In reply to aleth [:aleth] from comment #0)
> The tooltip only shows once its initial size doesn't fit on the screen,
> vertically at least. (Once it's shown, it can grow successfully.)

Sorry, a typo: it should be "The tooltip doesn't show if its initial vertical size doesn't fit on the screen."
(Reporter)

Comment 3

2 years ago
Could this be an edge case of bug 1075089?
Flags: needinfo?(nicko.robson)
(Assignee)

Comment 4

2 years ago
Can add a screenshot or video of the issue happening please?
Flags: needinfo?(nicko.robson)
(Reporter)

Comment 5

2 years ago
(In reply to nicko.robson from comment #4)
> Can add a screenshot or video of the issue happening please?

I don't see how I can screenshot a tooltip that doesn't appear...
(Assignee)

Comment 6

2 years ago
It's possible that the change has somehow affected how these tooltips are shown on OSX. The change has been in the mozilla codebase for around 6 weeks though and does seem to function correctly in Firefox when tooltips are position up against the bottom of the screen. Can you point me to the Instabird codebase so I can take a look?
(Assignee)

Comment 7

2 years ago
Actually, scrap that last comment, it does appear to have affected tooltips in the nightly firefox build. I will investigate further.
(Reporter)

Comment 8

2 years ago
(In reply to nicko.robson from comment #7)
> Actually, scrap that last comment, it does appear to have affected tooltips
> in the nightly firefox build. I will investigate further.

Thanks!
(Reporter)

Updated

2 years ago
Blocks: 1075089
Component: Contacts window → XUL
Product: Instantbird → Core
Version: trunk → Trunk
(Reporter)

Updated

2 years ago
Whiteboard: [1.6-blocking]
(Assignee)

Comment 9

2 years ago
Created attachment 8676678 [details] [diff] [review]
0001-Bug-1216284-Tooltips-do-not-flip-correctly-on-OSX.patch

Proposed patch to revert flip behavior for tooltips only on OSX. Tests still to come.
Attachment #8676678 - Flags: review?(enndeakin)

Updated

2 years ago
Attachment #8676678 - Flags: review?(enndeakin) → review+
(Reporter)

Updated

2 years ago
Keywords: checkin-needed
(Reporter)

Comment 10

2 years ago
Sorry, didn't spot the bit about missing tests.
Keywords: checkin-needed
(Assignee)

Comment 11

2 years ago
Np. Tests are incoming... had some issues with the try server last night.
(Assignee)

Comment 12

2 years ago
Created attachment 8681624 [details] [diff] [review]
0001-Bug-1216284-Tooltips-do-not-flip-correctly-on-OSX-V2.patch

Now with test and successful Try run (minus the Windows tests which don't seem to be running at the moment) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4917835a9aa
Attachment #8676678 - Attachment is obsolete: true
Attachment #8681624 - Flags: review?(enndeakin)

Comment 13

2 years ago
Comment on attachment 8681624 [details] [diff] [review]
0001-Bug-1216284-Tooltips-do-not-flip-correctly-on-OSX-V2.patch

>+  },
>+  result: function(testname) {
>+    var buttonrect = document.getElementById("withtooltip").getBoundingClientRect();
>+    var rect = document.getElementById("thetooltip").getBoundingClientRect();
>+    var popupstyle = window.getComputedStyle(document.getElementById("thetooltip"), "");
>+    var buttonstyle = window.getComputedStyle(document.getElementById("withtooltip"), "");

buttonstyle is never used so just remove this last line.
Attachment #8681624 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 14

2 years ago
Created attachment 8682196 [details] [diff] [review]
0001-Bug-1216284-Tooltips-do-not-flip-correctly-on-OSX-V3.patch

V3 of patch with offending line removed.
Attachment #8681624 - Attachment is obsolete: true
(Assignee)

Comment 15

2 years ago
(In reply to aleth [:aleth] from comment #10)
> Sorry, didn't spot the bit about missing tests.

Hi Aleth, I can't add keywords yet and the patch has been approved now. Can you add checkin-needed again please.

Thanks
Flags: needinfo?(aleth)
(Reporter)

Updated

2 years ago
Assignee: nobody → nicko.robson
Status: NEW → ASSIGNED
Flags: needinfo?(aleth)
Keywords: checkin-needed

Comment 17

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc60908714bb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.