1216319 - Clear mTime from asyncStorage in Sync app after DataStore clear

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Michiel de Jong [:michielbdejong]]

The TV will send a command to clear all local data from the Sync app when the user logs out of FxA (and therefore disables Sync). When this command is received, all data should be wiped from Kinto.js, localStorage, and all DataStores to which the sync app has access (the TV browser will keep its local bookmarks/history outside the applicable DataStores).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1216319-clear-command > mozilla-b2g:master

Comment 2

[Michiel de Jong [:michielbdejong]]

New plan: listen for DataStore#clear operations, and react to that instead of getting the command through IAC.

Comment 3

[Michiel de Jong [:michielbdejong]]

Changed this so that it only clears `mTime` from `asyncStorage`. That's enough to make sure the DataStore is repopulated on next sync for that userId.

Should this operation fail, then on next logout/login it will be repeated.

It's not easy to see the last operation for a DataStore (you have to cursor through all the history), so instead I'm checking if the DataStore has zero records.

I created follow-up bug 1218420 in case we want to clear more than just the mTime, so that maybe we can get out of some data corruption situations, but that requires more thought to see how we can make that work both on the TV and on the phone (where the DataStore is never cleared).

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8676635 [details] [review]
[gaia] michielbdejong:1216319-clear-command > mozilla-b2g:master

Unfortunately, checking the size of the DataStore is probably not enough :( I left a comment on the PR

Comment 6

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8676635 [details] [review]
[gaia] michielbdejong:1216319-clear-command > mozilla-b2g:master

Can you give me feedback on the approach? I changed it so that the clear is done the next time the user comes back, it's safer when a retry is needed.

For read-write we will need to store the lastRevisionId per userid anyway, so that makes this code more reusable.

Will write the unit tests now.

Thanks!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8676635 [details] [review]
[gaia] michielbdejong:1216319-clear-command > mozilla-b2g:master

Looks good! Thanks for addressing the previous feedback.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8676635 [details] [review]
[gaia] michielbdejong:1216319-clear-command > mozilla-b2g:master

Thanks! I left a couple of comments more on the PR

Comment 9

[Michiel de Jong [:michielbdejong]]

Comments addressed and rebased, TreeHerder almost finished (98% atm).

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/927bcd0612d89925ead14a320c65ebd21b5d61e3