1216399 - Remove U+1F310 (GLOBE WITH MERIDIANS) from Fira

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Since Fira is the default font in Firefox OS and since U+1F310 (GLOBE WITH MERIDIANS) exists in Fira Sans, Gecko will always render the character with the glyph in Fira instead of Firefox Emoji.

We should remove it this character will be shown in Firefox Emoji just like any other U+1xxxx characters without the need to append a VS16.

Patryk, could you help? Please refer to the lengthy discussion in bug 1206844.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Makes sense, I will contact the font vendor and get them removed. Looks like the other competitor fonts don't seem to have the specific unicode number. I'll update you on the ETA.
Thanks!

Comment 2

[Patryk Adamczyk [:patryk] UX]

Pavel, I asked the vendor to remove some of the conflicting symbols from Fira.
Can you remove the following from the emoji font since they should be coming from Fira Sans instead.
00A9
00AE
2122
2328

Unless Tim can confirm that Fira will overwrite these with its symbols, so they don't need to be removed.

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Patryk Adamczyk [:patryk] UX from comment #2)
> Pavel, I asked the vendor to remove some of the conflicting symbols from
> Fira.
> Can you remove the following from the emoji font since they should be coming
> from Fira Sans instead.
> 00A9
> 00AE
> 2122
> 2328
> 
bug 1216672 created
we had only U+2122

> Unless Tim can confirm that Fira will overwrite these with its symbols, so
> they don't need to be removed.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

For BMP characters, Emoji and plain symbols co-exists, and Fira is overwriting Emoji. We can only target Emoji explicitly by using two code points, like U+2122 U+FE0F. U+FE0F is a code point called VS16 which will make Gecko render the symbol with Emoji font. When an Emoji is sent from other OS, we also expect it comes with an VS16.

For non-BMP characters like U+1F310, it is uncommon for it to accompany an VS16, so the only way to ensure we render the Emoji correctly is to remove it from the actual font.

So, to your question: no, we don't need them to be removed from Firefox Emoji.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(BMP means code points with only four hex digits, like U+1234 but not U+12345)

Comment 6

[Patryk Adamczyk [:patryk] UX]

I should have the new font delivered by Monday BTW.

Comment 7

[Patryk Adamczyk [:patryk] UX]

Attachment: FiraOTF4107.zip

Fira Sans without the glyphs mentioned. Can you push this in, Pavel?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for master

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed in master:
https://github.com/mozilla-b2g/moztt/commit/27de93fe66c3e80e157d157bd52ca99565351669