Closed Bug 1216416 Opened 4 years ago Closed 4 years ago

Fix -Wimplicit-fallthrough warnings in widget/cocoa

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

MOZ_FALLTHROUGH is an annotation to suppress clang's -Wimplicit-fallthrough warnings about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

widget/cocoa/nsChildView.mm:1664:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

widget/cocoa/nsChildView.mm:1761:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

widget/cocoa/nsNativeThemeCocoa.mm:3700:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
Attachment #8676027 - Flags: review?(spohl.mozilla.bugs)
Attachment #8676027 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/1117b2bc65c2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.