121642 - check malloc return in anti aliased scaled bitmap code

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect, P4)

Description

[kill this account]

as ftang noted in comment #17 of bug 119042 the return for malloc should
be tested

Comment 1

[kill this account]

http://lxr.mozilla.org/seamonkey/source/gfx/src/x11shared/nsXFontAAScaledBitmap.
cpp#998

1020   if (exp_len > sizeof(exp_buffer))
1021     expanded_data = (PRUint8*)malloc(expanded_width*expanded_height);

Comment 2

[Frank Tang]

give to shanjian

Comment 3

[Frank Tang]

shanjian is no longer working on mozilla for 2 years and these bugs are still
here. Mark them won't fix. If you want to reopen it, find a good owner first. 

Comment 4

[Travis Chase]

Mass Reassign Please excuse the spam

Comment 5

[Travis Chase]

Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all
the spam is his fault feel free to tar and feather him

Comment 6

[Travis Chase]

Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam

Comment 7

[Ryan Jones-Ward [:sciguyryan]]

Jungshik: Would it be acceptable to make this function (scale_imageAntiJag) return a PRBOOL indicating error / success to that its callers may check and take appropriate action on failure?

It seems there are a few points in this function that require memory assignment checks and returns on failure, also upgrading this to major because if one of these allocations fails (e.g. the one with the website link) we'd get |expanded_data[exp_index+j] = padded_src[padded_index]| which could then lead to a crash.

Comment 8

[Mats Palmgren (inactive)]

It looks like this code was removed around mozilla-1.9.0 or so.