1216434 - Stop symlinking to the object directory in |mach gradle-install|

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Just one step closer to removing the symlinking entirely.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r?sebastian

Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r?sebastian

This has always been possible with Gradle -- Gradle doesn't care where
in the file tree resources are found.  (Gradle is perfectly happy to
take resources from outside of the root project directory.)  IntelliJ,
however, displays resources outside of known "content roots" in
special and frankly unhelpful ways.  Here, we avoid that on a
technicality: IntelliJ doesn't acknowledge (or even register a content
root!) for the non-standard AndroidManifest.xml locations set in
build.gradle.  This means we don't see odd content roots in unexpected
places in IntelliJ.

With this change, the formerly failing command

mach clobber && mach configure && mach gradle-install

completes successfully.  That gets us one step closer to being able to
open Fennec in IntelliJ without running additional commands.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8676039 [details]
MozReview Request: Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r?sebastian

https://reviewboard.mozilla.org/r/22555/#review20095

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/2af1c76f67a479b01053a9524b5975c7f2527bf8
Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r=sebastian

Comment 4

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/2af1c76f67a4