Closed Bug 1216444 Opened 4 years ago Closed 4 years ago

Remove gkmedias for good

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

In bug 922912, we folded back gkmedias.dll info xul.dll, so in practice, there is no configuration left that exercises GKMEDIAS_SHARED_LIBRARY. And sure enough, it's been broken for months (at the very least since bug 1051146).

So we might as well remove it completely.
See the following try push for the full collection of the different errors enabling GKMEDIA_SHARED_LIBRARY causes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f6ed50b64ed
Comment on attachment 8676087 [details] [diff] [review]
Remove GKMEDIAS_SHARED_LIBRARY

LGTM.
Attachment #8676087 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/3f388e64bff8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1217492
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.