[TV] Login out from Sync should log the user out from FxA

RESOLVED FIXED in FxOS-S10 (30Oct)

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

unspecified
FxOS-S10 (30Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 attachment)

On TV, because FxA login is tied to Sync, login out from Sync should log the user out from FxA.
(Assignee)

Updated

3 years ago
Assignee: nobody → ferjmoreno
Blocks: 824026
Priority: -- → P1
Target Milestone: --- → FxOS-S10 (30Oct)
Created attachment 8676069 [details] [review]
[gaia] ferjm:bug1216451.sync.logout.fxa > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8676069 - Flags: review?(yliao)
See Also: → bug 1194104
Comment on attachment 8676069 [details] [review]
[gaia] ferjm:bug1216451.sync.logout.fxa > mozilla-b2g:master

LGTM. Thank you! After this patch I assume we also need some changes after bug 1194014.
Attachment #8676069 - Flags: review?(yliao) → review+
(Assignee)

Comment 3

3 years ago
Not sure how is that bug related :\
Flags: needinfo?(yliao)
Ah sorry that's a typo, it should be bug 1194104. The disconnect button uses fxa_iac_client.js. Guess you've done it in bug 1194097 & bug 1194096.
Flags: needinfo?(yliao)
(Assignee)

Comment 5

3 years ago
Ah, right :)

I am removing all that code on bug 1194096.
(Assignee)

Comment 6

3 years ago
https://github.com/mozilla-b2g/gaia/commit/0ad8e1e3b51542dcc4d8465238badd659924fbe4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.