Closed Bug 1216451 Opened 9 years ago Closed 9 years ago

[TV] Login out from Sync should log the user out from FxA

Categories

(Firefox OS Graveyard :: Sync, defect, P1)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1216451.sync.logout.fxa > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
Details | Review 
On TV, because FxA login is tied to Sync, login out from Sync should log the user out from FxA.
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Priority: -- → P1
Target Milestone: --- → FxOS-S10 (30Oct)
Attachment #8676069 - Flags: review?(yliao)
See Also: → 1194104
Comment on attachment 8676069 [details] [review]
[gaia] ferjm:bug1216451.sync.logout.fxa > mozilla-b2g:master

LGTM. Thank you! After this patch I assume we also need some changes after bug 1194014.
Attachment #8676069 - Flags: review?(yliao) → review+
Not sure how is that bug related :\
Flags: needinfo?(yliao)
Ah sorry that's a typo, it should be bug 1194104. The disconnect button uses fxa_iac_client.js. Guess you've done it in bug 1194097 & bug 1194096.
Flags: needinfo?(yliao)
Ah, right :)

I am removing all that code on bug 1194096.
https://github.com/mozilla-b2g/gaia/commit/0ad8e1e3b51542dcc4d8465238badd659924fbe4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: