Closed
Bug 1216489
Opened 9 years ago
Closed 7 years ago
Simplify TabsPanel (Support for multiple heights, dragging, ..)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: sebastian, Assigned: twointofive, Mentored)
References
Details
Attachments
(3 files)
After bug 1204917 lands we will have a full screen tabs tray on phones and tablets. There's still code that calculates the height of the tabs tray and handles clicks outside of the panel to close it. We now can get rid of that.
|
Reporter | |
Updated•9 years ago
|
Blocks: tabs-tray-v3
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8842086 [details] Bug 1216489 - 1. Cleanup TabsPanel includes and remove member variable. https://reviewboard.mozilla.org/r/116054/#review117790
Attachment #8842086 -
Flags: review?(s.kaspari) → review+
|
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8842087 [details] Bug 1216489 - 2. Cleanup width and height calculations in TabsPanel. https://reviewboard.mozilla.org/r/116056/#review117792
Attachment #8842087 -
Flags: review?(s.kaspari) → review+
|
|
Reporter | |
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8842088 [details] Bug 1216489 - 3. Remove unnecessary touch intercept code for TabsPanel. https://reviewboard.mozilla.org/r/116058/#review117794
Attachment #8842088 -
Flags: review?(s.kaspari) → review+
|
|
Reporter | |
Comment 7•7 years ago
|
||
Thanks for taking care of this :)
Pushed by twointofive@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b96ede867359 1. Cleanup TabsPanel includes and remove member variable. r=sebastian https://hg.mozilla.org/integration/autoland/rev/baa3bfef08bd 2. Cleanup width and height calculations in TabsPanel. r=sebastian https://hg.mozilla.org/integration/autoland/rev/df546ad502ce 3. Remove unnecessary touch intercept code for TabsPanel. r=sebastian
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b96ede867359 https://hg.mozilla.org/mozilla-central/rev/baa3bfef08bd https://hg.mozilla.org/mozilla-central/rev/df546ad502ce
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•