Settings screen is not using accentColor anymore

RESOLVED FIXED in Firefox 44

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: mcomella)

Tracking

unspecified
Firefox 44
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed, fennec44+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8676209 [details]
settings-accentColor.png

See attached screenshot: The settings screen is not using the accentColor anymore (Android 5 & 6).
Flags: needinfo?(michael.l.comella)
Assignee: nobody → michael.l.comella
tracking-fennec: --- → 44+
Flags: needinfo?(michael.l.comella)
Created attachment 8676436 [details]
MozReview Request: Bug 1216503 - Have GeckoPrefs inherit from Gecko on 5+. r=sebastian

Bug 1216503 - Have GeckoPrefs inherit from Gecko on 5+. r=sebastian

Before we inherited from GeckoBase, which did not have the colorAccent
attribute.
Attachment #8676436 - Flags: review?(s.kaspari)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8676436 [details]
MozReview Request: Bug 1216503 - Have GeckoPrefs inherit from Gecko on 5+. r=sebastian

https://reviewboard.mozilla.org/r/22707/#review20361

Yay! Everything is beautiful again. :)
Attachment #8676436 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/5c9a1a6832a6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.