121654 - Browser hangs when viewing a Ja message w/o MIME header with folder charset set to Arabic (IBM-864)

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

*****Observed with windows 01/22 and linux 01/23 build****

When folder charset is set to Arabic(IBM-864), the 1st one on the folder charset
list, selecting a Ja message w/o MIME header causes browser hang.

Steps to reproduce:
1. Launch Mail.
2. Set the folder charset to Arabic (IBM-864)
3. Select a Ja message w/o MIME header (I'll attach the testing mail later),
browser hangs.

Comment 1

[ji]

Attachment: A testing Japanese ISO-2022-JP mail.

Comment 2

[ji]

Nominating for nsbeta1, since it's a regression and hang problem.

Comment 3

[marina]

Xianglan, is your folder an IMAP or POP? I can not reproduce it with an imap
folder..

Comment 4

[ji]

It's an IMAP folder. Did you use the testing mail? I noticed that among the
testing mails I have, this only happens to this mail and another mail which both
of them all have non-MIME encoded senders and recipients. And it doesn't happen
to other languages too, like Chinese.

Comment 5

[marina]

yes, i can reproduce the hang if i copy this mail to my local folder, and only
with this type, i have messages with nomime in the body or in headers and they
do not hang... wierd. 

Comment 6

[Frank Tang]

nsbeta1+ per bug triage .
smontagu , please talk to ji about this. 

Comment 7

[Simon Montagu :smontagu]

Does this bug still occur? I haven't succeeded in reproducing it, and it is
conceivably a dupe of bug 123380.

Comment 8

[ji]

It still hangs with 02/25 comm. build on my system.

Comment 9

[Simon Montagu :smontagu]

Odd. I see the hang in Mozilla milestone 0.9.8, but not in a Mozilla trunk build
from this morning.

Comment 10

[Simon Montagu :smontagu]

I don't see the hang in my own comm. build either

Comment 11

[Simon Montagu :smontagu]

I think I have pinned this down. This is the case which I said that I couldn't
find in http://bugzilla.mozilla.org/show_bug.cgi?id=82347#c16 

Comment 12

[Simon Montagu :smontagu]

Attachment: Fix

Comment 13

[Simon Montagu :smontagu]

mkaply, could you review the patch?

Comment 14

[Mike Kaply [:mkaply]]

Comment on attachment 72170 [details] [diff] [review]
Fix

r=mkaply

Comment 15

[kinmoz]

Comment on attachment 72170 [details] [diff] [review]
Fix

sr=[e-mail]

Do you want to indent the define's continuation lines like they do for the
other defines?

Comment 16

[Simon Montagu :smontagu]

Attachment: Changed alignment per comment 15

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 72462 [details] [diff] [review]
Changed alignment per comment 15

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 18

[Simon Montagu :smontagu]

Fix checked in.

Comment 19

[ji]

Verified as fixed with 03/20 builds.