Remove fetch RequestCache until we can implement

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bkelly, Assigned: Ehsan)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed, firefox44 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Currently we define the webidl for RequestCache, but don't implement it.  We should remove this webidl until its fully implemented so sites can feature detect it.

This should be uplifted to beta/aurora so that they can reasonably feature detect for the next few months until we release the real implementation.
(Reporter)

Comment 1

3 years ago
Note, this is just to hide the Request.cache property.  We should keep the RequestCache enum since we already set it properly on the Request and plumb it all down into Cache.

We just should hide the property so people can feature detect where its useful for or not.  Once FetchDriver looks at we can expose the property.
Blocks: 1059784
(Reporter)

Comment 2

3 years ago
This should probably be behind a pref like RequestContext to avoid removing all our tests and then re-adding them later.
(Reporter)

Comment 3

3 years ago
Any chance you have the bandwidth for this?  The window is closing before the next merge, and I have some other bugs I'm working on that also need to happen before merge.
Flags: needinfo?(ehsan)
(Assignee)

Comment 4

3 years ago
Sure!
Assignee: bkelly → ehsan
Flags: needinfo?(ehsan)
(Assignee)

Comment 5

3 years ago
Created attachment 8678152 [details] [diff] [review]
Unship Request.cache until the implementation is finished
Attachment #8678152 - Flags: review?(bzbarsky)
Comment on attachment 8678152 [details] [diff] [review]
Unship Request.cache until the implementation is finished

This diff is missing test_request_cache.html.

r=me with it added, but I'd like to see that test file.
Attachment #8678152 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

3 years ago
Created attachment 8678248 [details] [diff] [review]
Unship Request.cache until the implementation is finished

Sorry for the missing file!
(Assignee)

Comment 9

3 years ago
Comment on attachment 8678248 [details] [diff] [review]
Unship Request.cache until the implementation is finished

Approval Request Comment
[Feature/regressing bug #]: We accidentally exposed this attribute without having a full implementation.  I'd like to backport this patch that hides it so that web developers can feature detect it.
[User impact if declined]: Web developers won't be able to feature detect whether we support Request.cache, and would have to look at the UA string version number of other terrible hacks like that.
[Describe test coverage new/current, TreeHerder]: Locally.
[Risks and why]: This is pretty harmless.
[String/UUID change made/needed]: None.
Attachment #8678248 - Flags: approval-mozilla-beta?
Attachment #8678248 - Flags: approval-mozilla-aurora?
status-firefox42: --- → affected
status-firefox43: --- → affected
status-firefox44: --- → affected
Comment on attachment 8678248 [details] [diff] [review]
Unship Request.cache until the implementation is finished

This is really late :/ Taking it because we don't have much choice.
Should be in 42 rc1.
Attachment #8678248 - Flags: approval-mozilla-beta?
Attachment #8678248 - Flags: approval-mozilla-beta+
Attachment #8678248 - Flags: approval-mozilla-aurora?
Attachment #8678248 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/f4bed10ca33f
https://hg.mozilla.org/mozilla-central/rev/95f191207f8d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.