Open Bug 1216698 Opened 4 years ago Updated 4 years ago

Line between menu bar and tab bar

Categories

(Firefox :: Theme, defect)

44 Branch
Unspecified
Linux
defect
Not set

Tracking

()

UNCONFIRMED

People

(Reporter: michel, Unassigned)

Details

Attachments

(1 file)

Attached image Screenshot.png
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151020031317

Steps to reproduce:

I installed nightly on Debian Jessie with GNOME 3.16.2 kernel 4.2.1-2.


Actual results:

As title


Expected results:

No line there
Blocks: ship-gtk3
OS: Unspecified → Linux
Not sure why this issue was marked a GTK3 blocker. It shows up even in GTK2, so I would assume it is intentional, or at least some aspect of the theme. Why is this line not supposed to be there?
No longer blocks: ship-gtk3
(In reply to Lee Salzman [:lsalzman] from comment #1)
> Not sure why this issue was marked a GTK3 blocker. It shows up even in GTK2,

How do you know this? The report is from 44 as nightly, which ran gtk3. I assumed that stable, which would have been running gtk2, did not have a line.

> so I would assume it is intentional, or at least some aspect of the theme.
> Why is this line not supposed to be there?

I would concur with this, but that would simply mean marking this wontfix as far as GTK is concerned.

Can Firefox override these borders from CSS if they are part of the moz-appearance of the toolbar, without removing all of the -moz-appearance?
Flags: needinfo?(lsalzman)
(In reply to :Gijs Kruitbosch from comment #2)
> (In reply to Lee Salzman [:lsalzman] from comment #1)
> > Not sure why this issue was marked a GTK3 blocker. It shows up even in GTK2,
> 
> How do you know this? The report is from 44 as nightly, which ran gtk3. I
> assumed that stable, which would have been running gtk2, did not have a line.
> 
> > so I would assume it is intentional, or at least some aspect of the theme.
> > Why is this line not supposed to be there?
> 
> I would concur with this, but that would simply mean marking this wontfix as
> far as GTK is concerned.
> 
> Can Firefox override these borders from CSS if they are part of the
> moz-appearance of the toolbar, without removing all of the -moz-appearance?

Theming issues are not my forte, so that is a question better left for others.
Flags: needinfo?(lsalzman)
(In reply to :Gijs Kruitbosch from comment #2)
> Can Firefox override these borders from CSS if they are part of the
> moz-appearance of the toolbar, without removing all of the -moz-appearance?

AFAIK -moz-appearance has always been all or nothing.  I haven't looked at what exactly is drawing the lines, so I don't know whether it would be possible to add a control, but I suspect it would be fragile wrt different themes.

If the intention is that the menu bar should not look like a menu bar, then -moz-appearance: menubar is not suitable.  IMO though, it should look like a menubar.
You need to log in before you can comment on or make changes to this bug.