Camera should not delay viewfinder fadein on startup

VERIFIED FIXED in Firefox OS v2.5

Status

Firefox OS
Gaia::Camera
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
FxOS-S10 (30Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.5 verified, b2g-master verified)

Details

Attachments

(2 attachments)

There is currently a short delay on fading in the viewfinder which does not appear to serve any purpose (besides simplifying the code a bit). Since the critical path doesn't finish until the fade in is complete, and other Gecko events are often waiting on the thread (including repaints which we would want to be ready for), it can make the operation take longer than it should.
Assignee: nobody → aosmond
Blocks: 1210849
Status: NEW → ASSIGNED

Comment 1

2 years ago
Created attachment 8676441 [details] [review]
[gaia] aosmond:bug1216702 > mozilla-b2g:master
Attachment #8676441 - Flags: review?(dmarcos)
Attachment #8676441 - Flags: review?(dmarcos) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/941448101268d1cb8a520830b039fa602a4b58f8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
Depends on: 1217992

Comment 3

2 years ago
Created attachment 8683005 [details]
verified_Aries KK v2.6.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest Flame KK v2.6 512mb & v2.6 512mb and Aries KK v2.6.

Actual results: Camera dose not delay viewfinder fadein on startup.
See attachment: verified_Aries KK v2.6.3gp
Reproduce rate: 0/6

Device: Flame KK v2.5 512mb (master) (Pass)
Build ID               20151103004501
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4e0955369a51850f2982087145ac5c2df257ffe9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.054921
Firmware Date          Tue Nov  3 05:49:36 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master) (Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.6 (master) (Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1

Updated

2 years ago
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
status-b2g-v2.5: --- → verified
status-b2g-master: fixed → verified
You need to log in before you can comment on or make changes to this bug.