1216745 - [Flame][Music] When the Music app is loading new files the UI covers up the "Back" button on the player preventing users from changing away from the "now playing" page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Michael Bryant (uber)]

After putting new music on a Flame and launching the music app the application will begin adding new files to its library. However if you begin playing a song the dialogue for those new files being added to the library will overlap the "back" button on the now playing page. At this point the user is stuck on the now playing page unless you use task manager to kill the application. This problem isn't too horrible if you're only adding a few songs to the Music player but I've noticed that if you add a larger number of songs, around 40+, then the loading songs overlay will get stuck and not go away until you use task manager to kill the application

STR:
1) Put music on (40+ songs should provide you with enough time to see the issue) a SD Card, insert it in a Flame.
2) Reboot the Flame and launch the Music application.
3) The UI will have a section near the top showing all the new files being added to your library.
4) Pick and start playing a song. the adding new files dialogue overlaps the spot where the back button normally resides.

Flame Build Info:
Build ID               20151019030208
Gaia Revision          f75bd584aca0a751a5bed115800250faa8412927
Gaia Date              2015-10-19 06:39:58
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1a157155a4fe0074b3d03b54fe9e466472c2cd56
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  65
Firmware Date          Mon Dec 15 18:51:29 CST 2014
Bootloader             L1TC000118D0

Comment 1

[Hubert Figuiere [:hub]]

I have noticed this too.

Comment 2

[Jim Porter (:squib)]

The OGA logic is that we should only show the scanning process on the top-level views (i.e. things without a back button). I'll take a look at this.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:music-hide-scan > mozilla-b2g:master

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8681521 [details] [review]
[gaia] jimporter:music-hide-scan > mozilla-b2g:master

I changed the semantics here so that the "hidden" attribute is for users of this component to selectively hide the element. The automatic hiding when there's nothing to scan happens by showing/hiding the only child of the component. I think that's closer to describing the actual semantics we want here.

Comment 5

[Jim Porter (:squib)]

[Blocking Requested - why for this release]: This is pretty bad behavior, and can make it much more difficult to back out of a "pick" activity if you're trying to pick a song.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8681521 [details] [review]
[gaia] jimporter:music-hide-scan > mozilla-b2g:master

LGTM. Thanks!

Comment 7

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/3e32cb1613e791a713027965a6b0cd2f1d31bff4

Comment 8

[Mahendra Potharaju [:mahe]]

Jim,Can you set the 2.5 approval request flag and answer the questions there. 

Will help with approval for uplift. 

Thanks

Comment 9

[Jim Porter (:squib)]

Isn't it already approved?

Comment 10

[Jim Porter (:squib)]

Comment on attachment 8681521 [details] [review]
[gaia] jimporter:music-hide-scan > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: This is pretty bad behavior, and can make it much more difficult to back out of a "pick" activity if you're trying to pick a song.
[Testing completed]: Manually tested
[Risk to taking this patch] (and alternatives if risky): Low-risk
[String changes made]: None

Comment 11

[Mahendra Potharaju [:mahe]]

Comment on attachment 8681521 [details] [review]
[gaia] jimporter:music-hide-scan > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 12

[Michael Bryant (uber)]

Verified this as fixed. The new files being added UI no longer covers up the back button.

Build Info:
Build ID               20151119222736
Gaia Revision          ffaade435bb9c3005fd6c9b7ee1cd17b90e08cbf
Gaia Date              2015-11-19 03:07:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a76322320837ac6d0c9510c280706359a47ea309
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151119.214634
Firmware Date          Thu Nov 19 21:46:44 UTC 2015
Bootloader             L1TC000118D0

Comment 13

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/9d5d2f73079da75157a3af82e7780d2c12428867 for 2.5

Comment 14

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5&master by the STR in comment 0.

Actual results: When the Music app is loading new files the UI does not cover up the "Back" button on the player preventing users from changing away from the "now playing" page.
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Aries KK v2.5 (Pass)
Build ID               20151125233358
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224212
Firmware Date          Wed Nov 25 22:42:20 UTC 2015
Bootloader             s1

Device: Aries KK master (Pass) 
Build ID               20151125021621
Gaia Revision          37250b125e0db6966875d3b37b117f6d9b76cbc0
Gaia Date              2015-11-24 16:21:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/099f695d31326c39595264c34988a0f4b7cbc698
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.012004
Firmware Date          Wed Nov 25 01:20:12 UTC 2015
Bootloader             s1

Device: Flame 2.5 (512mb) (Pass)
Build ID               20151125234005
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224957
Firmware Date          Wed Nov 25 22:50:06 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp