Closed Bug 1216801 Opened 9 years ago Closed 9 years ago

Search suggestions should not be enabled in private browsing

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios-v1.1 --- verified
fxios 1.1+ ---

People

(Reporter: bnicholson, Assigned: bnicholson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1181
48 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
Search suggestions send your query to a search provider. This should be disabled in private browsing.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED

        Attachment #8676555 -
        Flags: review?(sleroux)

    
    

    
  
Is that what we do on Android?

    
    

    
  
Yep.

    
    

    
  
Comment on attachment 8676555 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1181

Looks good - nice catch!

        Attachment #8676555 -
        Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: pbmode

    
    

    
  
Verified on Beta 1113 that the search suggestion are disabled in private browsing
Status: RESOLVED → VERIFIED

          status-fxios-v1.1:
          affected → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: