1216809 - FTU will skip extra pages around the FxA page when not connected to a network.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

Description

[Martin Shuman [:Marty]]

Attachment: logcat_FTU-No-Network-Skip.txt

Description:
If the user is not connected to a network, the FTU will automatically skip the Firefox Account page, however, the FTU will also automatically skip the next page as well.  This occurs in both directions. If progressing forward, the FTU will skip the first About Firefox OS page, which has the Metrics opt-out options.  If navigating backwards, the FTU will skip the Contact Import screen.

Repro Steps:
1) Update an Aries to 20151020162500
2) Progress through the FTU without connecting to a WiFi or Data network.
3) Navigate back and forth between the Geolocation page, and the About Firefox OS page.

Actual:
When not connected to a network, the FTU will skip the Firefox Account page, but will also skip the next page in order.

Expected:
The FTU will only skip the Firefox Account page.

Environmental Variables:
Device: Aries 2.5
Build ID: 20151020162500
Gaia: 3491a49da4d4ce45b8a682e95d0ce68892c2b8ea
Gecko: f7b746b4e91307448cb0746a41f677bfc23908b0
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
When not connected to a network, the FTU will skip the Firefox Account page, but will also skip the next page in order.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151020031318
Gaia: 3491a49da4d4ce45b8a682e95d0ce68892c2b8ea
Gecko: f7b746b4e91307448cb0746a41f677bfc23908b0
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

***********************************

This issue does NOT ocurr on the latest Flame 2.2 build.
The FTU will only skip the Firefox Account page.

Environmental Variables:
Device: Flame 2.2
BuildID: 20151020032711
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 6b4e563acaf9
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Sam Foster [:sfoster] (he/him)]

And this is a regression? Strange indeed. Thanks I'll look into it. Nominating as a blocker. 

[Blocking Requested - why for this release]: Functional regression, user may not be presented with some FTU screens on first-time use.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:ftu-skip-step-bug-1216809 > mozilla-b2g:master

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8677187 [details] [review]
[gaia] sfoster:ftu-skip-step-bug-1216809 > mozilla-b2g:master

Can you check this over Reza? Let me know if I can help you find your way around the FTU and testing it.

Comment 5

[Reza Akhavan [:jedireza]]

Comment on attachment 8677187 [details] [review]
[gaia] sfoster:ftu-skip-step-bug-1216809 > mozilla-b2g:master

Tested locally. FTU no longer skips the Firefox Accounts screen when there is no network connection.

Code looks good. Gij28 is failing [1], although I don't suspect it's from your changes. It's always good to make sure though.

Comment 6

[Reza Akhavan [:jedireza]]

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b7af42785ea29818cd2f69788f480f548ddf5105

Comment 7

[Reza Akhavan [:jedireza]]

(In reply to Reza Akhavan [:jedireza] from comment #5)
> Tested locally. FTU no longer skips the Firefox Accounts screen when there
> is no network connection.

Correction: FTU no longer skips pages besides Firefox Accounts, when there is no network connection.

Comment 8

[Sam Foster [:sfoster] (he/him)]

Thanks Reza. The Gij28 failure is the task manager icons test, I can be confident that is unrelated. 

Merged to master: https://github.com/mozilla-b2g/gaia/commit/c8bf4bb09dcbfcbc5bacaae7ddf15bf094779770

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: It does not skip the pages between the Geolocation page and the About Firefox OS page when device does not connect to a network in FTU. 
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151025150204
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151025.201952
Firmware Date          Sun Oct 25 20:20:05 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151025085903
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151025.081846
Firmware Date          Sun Oct 25 08:18:54 UTC 2015
Bootloader             s1