1216852 - [Browser] Unable to launch pinned page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Alison Shiue]

STR:
1. Pin some pages
2. Go back to home screen to tap pinned page card

Expected result:
1. Would bring/launch the pinned page

Actual result:
1. Nothing happens

[Flame]
Build ID               20151020150236
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151020.182846
Firmware Date          Tue Oct 20 18:28:58 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151021013240
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/605de27d4e7f530159842649c02075c578d7a4a5
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151021.005126
Firmware Date          Wed Oct 21 00:51:34 UTC 2015
Bootloader             s1

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Broken basic function

Comment 2

[Chris Lord [:cwiiis]]

Pretty certain I broke this in bug 1213883 (sorry). I'll work on this today, it's a bit difficult to maintain mouse and touch support and still have nice capabilities like being able to respond to 'click' handlers :(

As a quick work around, if you double-tap any pinned page, it will open.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1216852-homescreen-fix-launching-pinned-pages > mozilla-b2g:master

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8676749 [details] [review]
[gaia] Cwiiis:bug1216852-homescreen-fix-launching-pinned-pages > mozilla-b2g:master

LGTM!

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/40560216c6cde03696755aa8c5fd3ff319052140

Comment 6

[Alison Shiue]

Verified on

Test Build:
[Flame]
Build ID               20151022003617
Gaia Revision          1b902ff26547e2a6c896351a6a73b673f65e19b2
Gaia Date              2015-10-21 14:56:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/daa7d98525e859d32a3b3e97101e129a897192a1
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151021.235526
Firmware Date          Wed Oct 21 23:55:35 UTC 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151022003511
Gaia Revision          1b902ff26547e2a6c896351a6a73b673f65e19b2
Gaia Date              2015-10-21 14:56:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/daa7d98525e859d32a3b3e97101e129a897192a1
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151021.235445
Firmware Date          Wed Oct 21 23:54:53 UTC 2015
Bootloader             s1