1216901 - mach build faster doesn't refresh when jar.mn files are being changed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Always update backend output list files mtime from the base backend class

Comment 2

[Mike Hommey [:glandium]]

Attachment: Make the FasterMake backend reticulate splines when moz.build or jar.mn files are modified

Comment 3

[Mike Hommey [:glandium]]

Attachment: Make the FasterMake backend reticulate splines when moz.build or jar.mn files are modified

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8679827 [details] [diff] [review]
Make the FasterMake backend reticulate splines when moz.build or jar.mn files are modified

>+        # Add backend dependencies:
>+        mk.create_rule([self._backend_output_list_file]).add_dependencies(
>+            self.backend_input_files)

What is this used for? As far as I can tell, it seems to behave the same without it. Namely, the backend.RecursiveMakeBackend rule triggers when backend_input_files changes, which regenerates the faster-make backend as well. Looks good otherwise, if I'm understanding it correctly.

Comment 5

[Mike Hommey [:glandium]]

self.backend_iunput_files contains more files in the fastermake backend, so there are effectively more files that can trigger splines reticulations for that backend compared to the recursive make backend. And those are not actual dependencies for the recursive make backend either.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e22433400ec2
https://hg.mozilla.org/integration/mozilla-inbound/rev/b855984ff056

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out to hopefully fix the Win PGO bustage so I can merge inbound.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bd43c8ec7be
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0da0df3ed52

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec7ac102bcb9
https://hg.mozilla.org/integration/mozilla-inbound/rev/28116363f21a

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ec7ac102bcb9
https://hg.mozilla.org/mozilla-central/rev/28116363f21a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ec7ac102bcb9
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/28116363f21a

Comment 11

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion