1216916 - Can no longer drag after some unknown event - node and document leak

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Karl Tomlinson (:karlt)]

I'm seeing nsDragService::InvokeDragSession() returning early aborting the
drag because mSourceNode is non-null.  I don't have steps to reproduce, but
I've seen these symptoms before.  The only way to allow more drags to attach a
debugger and set mSourceNode to null.

mDoingDrag is false.  That with non-null mSourceNode implies that
StartDragSession() has not been called after a previous InvokeDragSession().
Nothing ensures that mSourceNode is reset after a failed InvokeDragSession().

mHasImage is true.  Nothing ensure that it is reset after a failed
InvokeDragSession().

Comment 1

[Karl Tomlinson (:karlt)]

The memory leak affects all platforms.

Comment 2

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a35bd7bb6d4

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1216916 clean up when InvokeDragSession() fails r?roc

bug 1216916 clean up when InvokeDragSession() fails r?roc

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1216916 clean up when InvokeDragSessionWithImage/Selection() fails r?roc

bug 1216916 clean up when InvokeDragSessionWithImage/Selection() fails r?roc

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8677107 [details]
MozReview Request: bug 1216916 clean up when InvokeDragSession() fails r?roc

https://reviewboard.mozilla.org/r/22885/#review20407

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8677108 [details]
MozReview Request: bug 1216916 clean up when InvokeDragSessionWithImage/Selection() fails r?roc

https://reviewboard.mozilla.org/r/22887/#review20409

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01e2ab74a7f8
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c2f2bdb911b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01e2ab74a7f8
https://hg.mozilla.org/mozilla-central/rev/5c2f2bdb911b