Closed Bug 1216916 Opened 4 years ago Closed 4 years ago

Can no longer drag after some unknown event - node and document leak

Categories

(Core :: Widget, defect)

42 Branch
Unspecified
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- wontfix
firefox44 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

(Keywords: memory-leak)

Attachments

(2 files)

I'm seeing nsDragService::InvokeDragSession() returning early aborting the
drag because mSourceNode is non-null.  I don't have steps to reproduce, but
I've seen these symptoms before.  The only way to allow more drags to attach a
debugger and set mSourceNode to null.

mDoingDrag is false.  That with non-null mSourceNode implies that
StartDragSession() has not been called after a previous InvokeDragSession().
Nothing ensures that mSourceNode is reset after a failed InvokeDragSession().

mHasImage is true.  Nothing ensure that it is reset after a failed
InvokeDragSession().
The memory leak affects all platforms.
Keywords: mlk
OS: Linux → All
Summary: Can no longer drag after some unknown event → Can no longer drag after some unknown event - node and document leak
Blocks: 1214751
bug 1216916 clean up when InvokeDragSession() fails r?roc
Attachment #8677107 - Flags: review?(roc)
bug 1216916 clean up when InvokeDragSessionWithImage/Selection() fails r?roc
Attachment #8677108 - Flags: review?(roc)
Comment on attachment 8677108 [details]
MozReview Request: bug 1216916 clean up when InvokeDragSessionWithImage/Selection() fails r?roc

https://reviewboard.mozilla.org/r/22887/#review20409
Attachment #8677108 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/01e2ab74a7f8
https://hg.mozilla.org/mozilla-central/rev/5c2f2bdb911b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.