Closed
Bug 1216917
Opened 9 years ago
Closed 9 years ago
"WeakSet is not a function" is not a helpful error message for calling "WeakSet()" without "new".
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1215814
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: arai, Unassigned)
Details
Attachments
(1 file)
1.14 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Reproduction steps:
1. run js shell
2. execute following code
WeakSet();
Actual result:
following error message is shown
typein:1:1 TypeError: WeakSet is not a function
Expected result
It shows more helpful message, like "Map()" shows following
typein:1:1 TypeError: calling a builtin Map constructor without new is forbidden
Comment 1•9 years ago
|
||
Now when we execute WeakSet(); now it shows a meaningful error message.
Attachment #8676807 -
Flags: review?(arai.unmht)
Updated•9 years ago
|
Attachment #8676807 -
Flags: review?(arai.unmht) → review+
Comment 2•9 years ago
|
||
The WeakSet constructor was already fixed in bug 1215814 (https://hg.mozilla.org/integration/mozilla-inbound/rev/76b54ac73786).
Reporter | ||
Comment 3•9 years ago
|
||
oops! O_o
Sorry simplyblue24, I should've checked more carefully!
Comment 4•9 years ago
|
||
@arai no worries :D
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•