Closed Bug 1216918 Opened 4 years ago Closed 4 years ago

Style the conversation window title bar in blue

Categories

(Hello (Loop) :: Client, defect, P2)

defect

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Iteration:
44.3 - Nov 2
Tracking Status
firefox44 --- fixed

People

(Reporter: RT, Assigned: Mardak)

References

Details

(Whiteboard: [web sharing])

User Story

Acceptance criteria:
- Style the conversation window title bar to blue per attached UX

Attachments

(3 files, 3 obsolete files)

No description provided.
Blocks: 1209713
User Story: (updated)
Rank: 15
Priority: -- → P2
Attached image wip screenshot (obsolete) —
What color should the blue be? It's not the same as the blue for buttons. Are we updating the text color in this bug as well? Icons? The screenshot in attachment 8676718 [details] doesn't have the recently added leave button.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attached patch wip (obsolete) — Splinter Review
Attached image popped out view (obsolete) —
Should the title bar be blue for the popped out view as well?
Sevaan can you please help with Ed's questions?
Flags: needinfo?(sfranks)
(In reply to Ed Lee :Mardak from comment #2)
> Created attachment 8677885 [details]
> wip screenshot
> 
> What color should the blue be? It's not the same as the blue for buttons.

That must be a colour profile issue. Use the same blue as the buttons, please.

> Are we updating the text color in this bug as well? Icons? The screenshot in
> attachment 8676718 [details] doesn't have the recently added leave button.

Icons and text should be white. The leave button can remain as is.

Thanks, Ed!
Flags: needinfo?(sfranks)
Attached image v1 screenshot
Update the normal and minimized view but not the expanded view
Attachment #8678206 - Flags: ui-review?(sfranks)
Attachment #8678206 - Flags: ui-review?(sfranks) → ui-review+
Attached patch v1Splinter Review
Neat. Fancy svg id/fragment selectors and css too ;)
Attachment #8677885 - Attachment is obsolete: true
Attachment #8677886 - Attachment is obsolete: true
Attachment #8677888 - Attachment is obsolete: true
Attachment #8678209 - Flags: review?(standard8)
Comment on attachment 8678209 [details] [diff] [review]
v1

Not sure if the changed css should be next to the relevant original/default selectors. Or group together all the loop stuff under some header.
Attachment #8678209 - Flags: review?(standard8) → review?(mdeboer)
Comment on attachment 8678209 [details] [diff] [review]
v1

Review of attachment 8678209 [details] [diff] [review]:
-----------------------------------------------------------------

Nope, no need to change anything here... super happy with it! My compliments on using the `src` attribute here to apply the different color.
Attachment #8678209 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/d2bb527a1e8a1c351640b2624e3dd1a0487488a2
Bug 1216918 - Style the conversation window title bar in blue [r=mikedeboer]
https://hg.mozilla.org/mozilla-central/rev/d2bb527a1e8a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Whiteboard: [web sharing]
Iteration: --- → 44.3 - Nov 2
You need to log in before you can comment on or make changes to this bug.