Tracking protection dialog has no exit transition

RESOLVED FIXED in FxOS-S11 (13Nov)

Status

Firefox OS
Gaia::System::Browser Chrome
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

({polish})

unspecified
FxOS-S11 (13Nov)
ARM
Gonk (Firefox OS)
polish

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe] [good-first-bug])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The new tracking protection dialog animates in, but does not animate out. The component it's using has exit transitions, so I guess it's being immediately hidden or removed from the DOM on user response.

It's especially jarring to have animations on one side of this dialog and not the other, should be an easy fix.

Comment 1

2 years ago
Created attachment 8681292 [details] [review]
[gaia] Cwiiis:bug1216926-tracking-protection-close-transition > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8681292 [details] [review]
[gaia] Cwiiis:bug1216926-tracking-protection-close-transition > mozilla-b2g:master

It's unlikely this would have happened if the gaia-dialog component was used - any reason why this was re-implemented?

We have a *lot* of dialog implementations in the tree, all with varying UX bugs. Over 10, last time I counted.
Attachment #8681292 - Flags: review?(apastor)
(Assignee)

Updated

2 years ago
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Comment on attachment 8681292 [details] [review]
[gaia] Cwiiis:bug1216926-tracking-protection-close-transition > mozilla-b2g:master

Thanks for taking care of this.
Attachment #8681292 - Flags: review?(apastor) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/0448f3798d0454277f583b2a9b6d4506b9a04f54
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in before you can comment on or make changes to this bug.