Closed
Bug 1216926
Opened 9 years ago
Closed 9 years ago
Tracking protection dialog has no exit transition
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
(Keywords: polish, Whiteboard: [systemsfe] [good-first-bug])
Attachments
(1 file)
The new tracking protection dialog animates in, but does not animate out. The component it's using has exit transitions, so I guess it's being immediately hidden or removed from the DOM on user response. It's especially jarring to have animations on one side of this dialog and not the other, should be an easy fix.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8681292 [details] [review] [gaia] Cwiiis:bug1216926-tracking-protection-close-transition > mozilla-b2g:master It's unlikely this would have happened if the gaia-dialog component was used - any reason why this was re-implemented? We have a *lot* of dialog implementations in the tree, all with varying UX bugs. Over 10, last time I counted.
Attachment #8681292 -
Flags: review?(apastor)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8681292 [details] [review] [gaia] Cwiiis:bug1216926-tracking-protection-close-transition > mozilla-b2g:master Thanks for taking care of this.
Attachment #8681292 -
Flags: review?(apastor) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/0448f3798d0454277f583b2a9b6d4506b9a04f54
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•