Closed
Bug 1216955
Opened 9 years ago
Closed 9 years ago
Use chrome override for download-glow-menuPanel-XPVista7.png
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 45
People
(Reporter: dao, Assigned: harshitbansal2015, Mentored)
References
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 2 obsolete files)
|
4.20 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Instead of this rule: http://hg.mozilla.org/mozilla-central/annotate/d43374e69703/browser/themes/windows/downloads/indicator.css#l64 ... we should add that file to the overrides here: http://hg.mozilla.org/mozilla-central/annotate/d43374e69703/browser/themes/windows/jar.mn#l325
|
Assignee | |
Comment 1•9 years ago
|
||
Kindly review the proposed patch and tell if anything else needs to be done!!
Attachment #8683788 -
Flags: review?(dao)
Attachment #8683788 -
Flags: checkin?(dao)
|
||
Updated•9 years ago
|
Attachment #8683788 -
Flags: checkin?(dao)
|
|
||
Updated•9 years ago
|
Assignee: nobody → harshitbansal2015
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(jaws)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8683788 [details] [diff] [review] second.patch Review of attachment 8683788 [details] [diff] [review]: ----------------------------------------------------------------- This is the right idea, but... ::: browser/themes/windows/downloads/indicator.css @@ -65,5 @@ > -@media (-moz-os-version: windows-vista), > - (-moz-os-version: windows-win7) { > -%endif > - #downloads-button[cui-areatype="menu-panel"][attention] { > - list-style-image: url("chrome://browser/skin/downloads/download-glow-menuPanel-XPVista7.png"); This path: chrome://browser/skin/downloads/download-glow-menuPanel-XPVista7.png ::: browser/themes/windows/jar.mn @@ +321,5 @@ > > % override chrome://browser/skin/actionicon-tab.png chrome://browser/skin/actionicon-tab-XPVista7.png os=WINNT osversion<=6.1 > % override chrome://browser/skin/reload-stop-go.png chrome://browser/skin/reload-stop-go-XPVista7.png os=WINNT osversion<=6.1 > % override chrome://browser/skin/reload-stop-go@2x.png chrome://browser/skin/reload-stop-go-XPVista7@2x.png os=WINNT osversion<=6.1 > +% override chrome://browser/skin/download-glow-menuPanel.png chrome://browser/skin/download-glow-menuPanel.png-XPVista7.png os=WINNT osversion<=6.1 ... doesn't match this path: chrome://browser/skin/download-glow-menuPanel.png-XPVista7.png Nor, I think, does the path to the file you're overriding actually work. Did you test this patch? :-)
Attachment #8683788 -
Flags: review?(dao) → review-
|
|
||
Comment 3•9 years ago
|
||
(Also, please use an appropriate commit message for the next patch you provide. Thank you!)
Flags: needinfo?(jaws)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Kindly review the attached patch.
Attachment #8683788 -
Attachment is obsolete: true
Attachment #8684081 -
Flags: review?(dolske)
Attachment #8684081 -
Flags: checkin-
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8684081 -
Flags: checkin- → checkin?(dolske)
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8684081 [details] [diff] [review] second.patch >+% override chrome://browser/skin/downloads/download-glow-menuPanel.png chrome://browser/skin/downloads/download-glow-menuPanel.png-XPVista7.png os=WINNT osversion<=6.1 chrome://browser/skin/downloads/download-glow-menuPanel.png-XPVista7.png needs to be chrome://browser/skin/downloads/download-glow-menuPanel-XPVista7.png instead. Also please move this override between the chrome://browser/skin/urlbar-history-dropmarker@2x.png and the chrome://browser/skin/places/autocomplete-star.png overrides.
Attachment #8684081 -
Flags: review?(dolske)
Attachment #8684081 -
Flags: review-
Attachment #8684081 -
Flags: checkin?(dolske)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Attachment #8684081 -
Attachment is obsolete: true
Attachment #8684214 -
Flags: review?(dao)
Attachment #8684214 -
Flags: checkin?
|
|
Reporter | |
Comment 7•9 years ago
|
||
Comment on attachment 8684214 [details] [diff] [review] second.patch Looks good, thanks!
Attachment #8684214 -
Flags: review?(dao) → review+
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8684214 -
Flags: checkin?
|
|
Reporter | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/17194b40e1df
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in
before you can comment on or make changes to this bug.
Description
•