1217002 - Deploy splice 1.1.35 to stage

Status: RESOLVED FIXED

(Content Services Graveyard :: Tiles: Ops, defect)

Description

[Ricky Rosario [:rrosario, :r1cky]]

These are only UI changes. No python or DB changes.

Thanks!

Comment 1

[Daniel Thorn [:relud]]

Marc, do you have this, or should I do it?

Comment 2

[Marc Schifer [mschifer]]

I will need some instructions on what to do and how to do it. 
Is there anything on a wiki somewhere?
Also I don't have access to datadog

Comment 3

[Daniel Thorn [:relud]]

Attachment: android.json

:r1cky it's deployed in stage, but the UI changes seem have some issues:

The drop-down for re-deploying previous distributions is gone.
Images don't appear in the preview when using the attached payload.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Daniel Thorn [:relud] from comment #3)
> The drop-down for re-deploying previous distributions is gone.

Yeah, we removed that removed that feature because it isn't really used.

> Images don't appear in the preview when using the attached payload.

The problem with the tile images in that test file is they are white with a transparent background. I was able to see by hacking the CSS of the page. We should probably create a better file. Let me know if you need help with that.

Comment 5

[Daniel Thorn [:relud]]

If you upload android.json in the old UI the images appear to include background colors (blue, green, orange, and red). Not sure what the difference is, but something definitely changed there.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Daniel Thorn [:relud] from comment #5)
> If you upload android.json in the old UI the images appear to include
> background colors (blue, green, orange, and red). Not sure what the
> difference is, but something definitely changed there.

Ah, I just noticed the bgColor field. I am pretty sure I am not doing anything with that. I'll fix that but :nanj says that doesn't affect him.

Comment 7

[Daniel Thorn [:relud]]

> Yeah, we removed that removed that feature because it isn't really used.

It is used for testing splice, so we (ops & qa) can redeploy existing tile distributions.
I personally use it to view the currently deployed tile set.
It was also extremely helpful in the case where a bad tile set was mistakenly published to prod, and we needed to roll back to the most recent correct deploy.

Is there any way I could get some sort of 'load most recent tile set' button? That would fix the first two use cases for me.

Regardless, this is non-blocking.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Daniel Thorn [:relud] from comment #7)
> Is there any way I could get some sort of 'load most recent tile set'
> button? That would fix the first two use cases for me.

We were discussing adding a way to look at previous distributions that would work just like the Upcoming view. But it sounds like you want to be able to publish those. So we should probably just add that feature back in. No big deal.

For seeing what's currently in prod, you can use this previewer: http://rlr.github.io/webtiles-previewer-redux/

Comment 9

[Daniel Thorn [:relud]]

previewer - nice! If I also had a link to download a standard tile set to deploy to stage, then I'd be set, no need to bring the previous distributions feature back.

Comment 10

[Daniel Thorn [:relud]]

marking this bug as resolved, because 1.1.35 is deployed in stage. Please file a new bug when the bgColor bug is fixed, and we can get this (awesome) UI update to prod.