1217016 - [JavaScript Error: "TypeError: aSubject is null" {file: "chrome://browser/content/browser.js" line: 5856}]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I just saw this appear in a local build, and it points to this line:
https://hg.mozilla.org/mozilla-central/rev/69f447f55be7#l1.23

Vivek, can you take a look at this?

10-21 11:25:11.393  22246-22280/org.mozilla.fennec_leibovic E/GeckoConsole﹕ [JavaScript Error: "TypeError: aSubject is null" {file: "chrome://browser/content/browser.js" line: 5856}]
    XPInstallObserver.observe@chrome://browser/content/browser.js:5856:9
    XPI_verifySignatures/</<@resource://gre/modules/addons/XPIProvider.jsm:2993:9
    TaskImpl_run@resource://gre/modules/Task.jsm:314:40
    TaskImpl@resource://gre/modules/Task.jsm:275:3
    createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
    Task_spawn@resource://gre/modules/Task.jsm:164:12
    XPI_verifySignatures/<@resource://gre/modules/addons/XPIProvider.jsm:2966:7
    makeSafe/<@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:162:17
    asyncMap@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:190:5
    this.XPIDatabase.getAddonList/<@resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:1082:9
    Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend

Comment 1

[Vivek Balakrishnan[:vivek]]

Attachment: MozReview Request: Bug 1217016 : Added null check in xpi install observer r?margaret

Bug 1217016 : Added null check in xpi install observer  r?margaret

This definitely a fallout from 1201547. I failed to audit whether subject
is not null for all the notifications. Seems like it is null for
"xpi-signature-changed" [1].

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#2993

Comment 2

[:Margaret Leibovic]

Comment on attachment 8676940 [details]
MozReview Request: Bug 1217016 : Added null check in xpi install observer  r?margaret

https://reviewboard.mozilla.org/r/22839/#review20451

Thanks for looking into this so quickly! Feel free to land as-is, or with my suggestion below.

::: mobile/android/chrome/content/browser.js:5864
(Diff revision 1)
> -    if (installInfo.originatingURI) {
> +    if (installInfo && installInfo.originatingURI) {

For consistency, you could also declare `host` up above with `installInfo` and `tab`, and then set it in the `if (aSubject)` block.

Comment 3

[Vivek Balakrishnan[:vivek]]

https://hg.mozilla.org/integration/fx-team/rev/214bc95f9d20afb36016a0ff7021695a01f78c1b
Bug 1217016 : Added null check in xpi install observer  r=margaret

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/214bc95f9d20