1217055 - Remove Youtube UA override once Bug 1174784 is verified fixed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Taylor [:miketaylr]]

Just waiting on a complete roll-out of the fix.

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: 1217055.-Remove-UA-override-for-Youtube.-r.patch

Patch for when we're ready.

Comment 2

[Mike Taylor [:miketaylr]]

Youtube's fix has been rolled out for a while ago, let's pull the trigger on this one.

Comment 3

[Mike Taylor [:miketaylr]]

Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Margaret, would you mind rubber stamping this?

Comment 4

[Chris Peterson [:cpeterson]]

It would be nice if we could uplift this fix to Aurora 44 or Beta 43.

Comment 5

[Mike Taylor [:miketaylr]]

Agreed -- I'll request the approvals once this lands.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Review of attachment 8677029 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber stamped!

Comment 7

[:Margaret Leibovic]

I see Mike's bugzilla name says he's on PTO... let's get this landed for him.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0c0eb158331e

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c0eb158331e

Comment 10

[Mike Taylor [:miketaylr]]

Thanks Margaret (for review and landing)!

Comment 11

[Mike Taylor [:miketaylr]]

Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Approval Request Comment
[Feature/regressing bug #]:

Bug 1175301 added the override so we could have working video until Youtube fixed the video type they sent us (which they've done for a few weeks now -- see Bug 1174784).

[User impact if declined]: 

Play/pause behavior on m.youtube.com is weird and appears broken. See Bug 1225554 for details.

[Describe test coverage new/current, TreeHerder]:

None
[Risks and why]: 

No risks I can think of. This patch fixes the current broken behavior (and removes a workaround we had for an old bug). 

[String/UUID change made/needed]:
None

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Removes a workaround we added in 41. OK to uplift to aurora and beta.

Comment 13

[Mike Taylor [:miketaylr]]

Thanks Liz.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5b8ecbf7455c

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/354dd8f61077

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/5b8ecbf7455c

Comment 17

[u549602]

Verified as fixed on latest Beta build (43.0b8)
Tested on :
Sony Xperia Z2 - Android 5.0.2
HTC Desire S - Android 2.3.3
Samsung Galaxy S6 - Android 5.1.1 
ZTE Grand X IN - Android 4.0.4
Nexus 6 - Android 6.0