Closed Bug 1217055 Opened 8 years ago Closed 8 years ago

Remove Youtube UA override once Bug 1174784 is verified fixed

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 wontfix, firefox43 verified, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox42 --- wontfix
firefox43 --- verified
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

Attachments

(1 file)

1217055.-Remove-UA-override-for-Youtube.-r.patch
1.60 KB, patch
Margaret
: review+
lizzard
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Just waiting on a complete roll-out of the fix.
Patch for when we're ready.
Youtube's fix has been rolled out for a while ago, let's pull the trigger on this one.
Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Margaret, would you mind rubber stamping this?
Attachment #8677029 - Flags: review?(margaret.leibovic)
Blocks: 1225554
It would be nice if we could uplift this fix to Aurora 44 or Beta 43.
status-firefox42: --- → wontfix
status-firefox43: --- → affected
status-firefox44: --- → affected
status-firefox45: --- → affected
OS: Unspecified → Android
Agreed -- I'll request the approvals once this lands.
Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Review of attachment 8677029 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber stamped!
Attachment #8677029 - Flags: review?(margaret.leibovic) → review+
I see Mike's bugzilla name says he's on PTO... let's get this landed for him.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0c0eb158331e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Thanks Margaret (for review and landing)!
Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Approval Request Comment
[Feature/regressing bug #]:

Bug 1175301 added the override so we could have working video until Youtube fixed the video type they sent us (which they've done for a few weeks now -- see Bug 1174784).

[User impact if declined]: 

Play/pause behavior on m.youtube.com is weird and appears broken. See Bug 1225554 for details.

[Describe test coverage new/current, TreeHerder]:

None
[Risks and why]: 

No risks I can think of. This patch fixes the current broken behavior (and removes a workaround we had for an old bug). 

[String/UUID change made/needed]:
None
Attachment #8677029 - Flags: approval-mozilla-beta?
Attachment #8677029 - Flags: approval-mozilla-aurora?
Comment on attachment 8677029 [details] [diff] [review]
1217055.-Remove-UA-override-for-Youtube.-r.patch

Removes a workaround we added in 41. OK to uplift to aurora and beta.
Attachment #8677029 - Flags: approval-mozilla-beta?
Attachment #8677029 - Flags: approval-mozilla-beta+
Attachment #8677029 - Flags: approval-mozilla-aurora?
Attachment #8677029 - Flags: approval-mozilla-aurora+
Thanks Liz.
Verified as fixed on latest Beta build (43.0b8)
Tested on :
Sony Xperia Z2 - Android 5.0.2
HTC Desire S - Android 2.3.3
Samsung Galaxy S6 - Android 5.1.1 
ZTE Grand X IN - Android 4.0.4
Nexus 6 - Android 6.0
status-firefox43: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.