Closed Bug 1217065 Opened 4 years ago Closed 4 years ago

Unconditionally ack incoming updates

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: Lina, Assigned: Lina)

Details

Attachments

(1 file)

Currently, we only ack updates that decrypt successfully. This isn't good, because the Push server requires the client to ack all outstanding updates before resuming delivery.

However, the server doesn't check the encryption headers, and can't ensure that an update is encrypted correctly because it doesn't have the private key. Thus, it's possible for a single invalid update to block delivery of all subsequent ones.
Attachment #8676969 - Flags: review?(dd.mozilla)
Attachment #8676969 - Flags: review?(bbangert)
Comment on attachment 8676969 [details] [diff] [review]
0001-Bug-1217065-Unconditionally-ack-incoming-updates.-r-.patch

Review of attachment 8676969 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8676969 - Flags: review?(dd.mozilla) → review+
Comment on attachment 8676969 [details] [diff] [review]
0001-Bug-1217065-Unconditionally-ack-incoming-updates.-r-.patch

Review of attachment 8676969 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8676969 - Flags: review?(bbangert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/97c0692a9ce5336fb5579aa52581fba8eb79c32a
Bug 1217065 - Unconditionally ack incoming updates. r=dragana,benbangert
https://hg.mozilla.org/mozilla-central/rev/97c0692a9ce5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.