If Autoland hits an error reporting status to MozReview it should wait longer before trying again

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: dminor, Assigned: dminor)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
At the moment, this causes the error messages to pile up.
(Assignee)

Comment 1

3 years ago
Created attachment 8679080 [details]
MozReview Request: autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r=mdoglio

autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r?mdoglio

This adds a retry timeout if we hit an error posting to MozReview. The errors
we've seen so far are due to coding mistakes or misconfiguration so we don't
gain anything by retrying 4 times a second.

We also remove the requirement that the pingback_url be non-empty because it's
useful to leave the pingback_url empty when testing.
Attachment #8679080 - Flags: review?(mdoglio)
Attachment #8679080 - Flags: review?(mdoglio) → review+
Comment on attachment 8679080 [details]
MozReview Request: autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r=mdoglio

https://reviewboard.mozilla.org/r/23369/#review20895
(Assignee)

Comment 3

3 years ago
Comment on attachment 8679080 [details]
MozReview Request: autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r=mdoglio

autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r=mdoglio

This adds a retry timeout if we hit an error posting to MozReview. The errors
we've seen so far are due to coding mistakes or misconfiguration so we don't
gain anything by retrying 4 times a second.

We also remove the requirement that the pingback_url be non-empty because it's
useful to leave the pingback_url empty when testing.
Attachment #8679080 - Attachment description: MozReview Request: autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r?mdoglio → MozReview Request: autoland: wait between retries if we hit an error posting to mozreview (bug 1217068) r=mdoglio
(Assignee)

Comment 4

3 years ago
Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/ea1760f17be1
Assignee: nobody → dminor
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.