1217099 - Stop emitting pointless JSOP_GETLOCAL; JSOP_POP bytecode sequence for `var x;`

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

We've been doing this forever. With the emitVariables() and emitNormalFor() refactoring in bug 1217001, we can stop.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Stop emitting pointless JSOP_GETLOCAL; JSOP_POP bytecode sequence for `var x;`

Comment 2

[André Bargull [:anba]]

This should fix bug 320887, right?

Comment 3

[Jason Orendorff [:jorendorff]]

Yes. Good grief.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Stop emitting pointless JSOP_GETLOCAL; JSOP_POP bytecode sequence for `var x;`

Comment 5

[Jason Orendorff [:jorendorff]]

I added a test for bug 320887 to the patch.

Comment 7

[Shu-yu Guo [:shu]]

Comment on attachment 8677562 [details] [diff] [review]
Stop emitting pointless JSOP_GETLOCAL; JSOP_POP bytecode sequence for `var x;`

Review of attachment 8677562 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_5/Global/bug-320887.js
@@ +1,1 @@
> +// `var x` should not call the getter of an existing global property.

lol! :(

Comment 8

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2fa0d600192e096eb1c289b23f75410c45b744
Bug 1217099 - Stop emitting pointless JSOP_GETLOCAL; JSOP_POP bytecode sequence for `var x;`. r=shu.

Comment 9

[Guilherme Lima]

This landed yesterday - https://hg.mozilla.org/mozilla-central/rev/bc2fa0d60019