Closed Bug 1217110 Opened 5 years ago Closed 5 years ago

Remove unnecessary opcode JSOP_BINDINTRINSIC

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

Remove unnecessary opcode JSOP_BINDINTRINSIC
6.17 KB, patch
shu
: review+
Details | Diff | Splinter Review 
JSOP_BINDINTRINSIC's job is to push a value to the operand stack that is never used. JSOP_SETINTRINSIC discards it a few instructions later.

Not a big deal, but this is sort of pointless. We have other SET opcodes that do not have a matching BIND opcode: JSOP_SETLOCAL, JSOP_SETALIASEDVAR, and so on. We can make JSOP_SETINTRINSIC one of those.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8677014 [details] [diff] [review]
Remove unnecessary opcode JSOP_BINDINTRINSIC

Review of attachment 8677014 [details] [diff] [review]:
-----------------------------------------------------------------

Hurray.
Attachment #8677014 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/6cf9efd57929
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.