Closed
Bug 1217110
Opened 10 years ago
Closed 10 years ago
Remove unnecessary opcode JSOP_BINDINTRINSIC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
6.17 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
JSOP_BINDINTRINSIC's job is to push a value to the operand stack that is never used. JSOP_SETINTRINSIC discards it a few instructions later.
Not a big deal, but this is sort of pointless. We have other SET opcodes that do not have a matching BIND opcode: JSOP_SETLOCAL, JSOP_SETALIASEDVAR, and so on. We can make JSOP_SETINTRINSIC one of those.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8677014 -
Flags: review?(shu)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8677014 [details] [diff] [review]
Remove unnecessary opcode JSOP_BINDINTRINSIC
Review of attachment 8677014 [details] [diff] [review]:
-----------------------------------------------------------------
Hurray.
Attachment #8677014 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf9efd579290fe27af7a964f20727f92578385d
Bug 1217110 - Remove unnecessary opcode JSOP_BINDINTRINSIC. r=shu.
|
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•