Closed Bug 1217198 Opened 4 years ago Closed Last year

Multiline string autocompletion is not triggered for `foo bar`

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: bgrins, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [boogaloo-mvp])

Attachments

(2 files)

After Bug 1216668, it works for:

* `foo`.
* `foo
   bar`.

But typing `foo bar`. doesn't open up the autocompletion popup
Failing test case
This bug should be used to investigate switching from the combo of hand rolled parsing and Parser.jsm to using acorn to tokenize the input string.
Depends on: 1226810
Product: Firefox → DevTools
Blocks: 1458831
Priority: -- → P3
Whiteboard: [boogaloo-reserve]
Assignee: nobody → nchevobbe
Blocks: 1476656
Status: NEW → ASSIGNED
Priority: P3 → P1
Add a new template literal state to findCompletionBeginning so we can
better handle the autocompletion for them.
Whiteboard: [boogaloo-reserve] → [boogaloo-mvp]
Comment on attachment 9005990 [details]
Bug 1217198 - Better autocompletion for template literals; r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9005990 - Flags: review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc074d42aa91
Better autocompletion for template literals; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/bc074d42aa91
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.