Closed
Bug 1217198
Opened 9 years ago
Closed 6 years ago
Multiline string autocompletion is not triggered for `foo bar`
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: bgrins, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: [boogaloo-mvp])
Attachments
(2 files)
After Bug 1216668, it works for: * `foo`. * `foo bar`. But typing `foo bar`. doesn't open up the autocompletion popup
Reporter | ||
Comment 1•9 years ago
|
||
Failing test case
Reporter | ||
Comment 2•9 years ago
|
||
This bug should be used to investigate switching from the combo of hand rolled parsing and Parser.jsm to using acorn to tokenize the input string.
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Add a new template literal state to findCompletionBeginning so we can better handle the autocompletion for them.
Assignee | ||
Comment 4•6 years ago
|
||
TRY push https://treeherder.mozilla.org/#/jobs?repo=try&revision=eee2fdca707f7eb8cd803da507a00d6220e7d114&selectedJob=197171453
Updated•6 years ago
|
Whiteboard: [boogaloo-reserve] → [boogaloo-mvp]
Comment 5•6 years ago
|
||
Comment on attachment 9005990 [details] Bug 1217198 - Better autocompletion for template literals; r=Honza. Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9005990 -
Flags: review+
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc074d42aa91 Better autocompletion for template literals; r=Honza.
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc074d42aa91
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•