Tab increment animation is broken for popup windows

VERIFIED FIXED

Status

()

Firefox for iOS
Browser
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: fluffyemily)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v1.1 affected, fxios1.2+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
bnicholson
: review+
tecgirl
: ui-review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
STR:
1) Go to http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open.
2) Click "Try it".

The tab count animation should be a card-like flip from the bottom, but instead shows a weird effect where the counter expands from the middle.
(Assignee)

Updated

3 years ago
Assignee: nobody → etoop
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8677485 [details] [review]
Pull request

UIReview just in case I missed an tab count animation scenario somewhere. My eyes are not as eagle as some.
Attachment #8677485 - Flags: ui-review?(randersen)
Attachment #8677485 - Flags: review?(bnicholson)
Attachment #8677485 - Flags: ui-review?(randersen) → ui-review+
(Reporter)

Comment 2

3 years ago
Comment on attachment 8677485 [details] [review]
Pull request

Animation is fixed, but this crashes every time I open a new private tab :(
Attachment #8677485 - Flags: review?(bnicholson) → review-
(Assignee)

Updated

3 years ago
Attachment #8677485 - Flags: review- → review?(bnicholson)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8677485 [details] [review]
Pull request

Nice, works well.
Attachment #8677485 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
tracking-fxios: ? → 1.2+
Verifying as fixed on Beta 1.2 (1201)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.