Closed Bug 1217250 Opened 4 years ago Closed 4 years ago

Some IPDL C++ regression tests are busted

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file, 1 obsolete file)

Looks like some Length() -> Count() conversions were missed.
TestMultiMgrs.cpp
TestManyChildAllocs.cpp
Attached patch Fixes (obsolete) — Splinter Review
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8677175 - Flags: review?(nfroyd)
Comment on attachment 8677175 [details] [diff] [review]
Fixes

Review of attachment 8677175 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

r=me with the changes below if you can use ProtocolUtils.h in this code, otherwise r=me as is.

::: ipc/ipdl/test/cxx/TestMultiMgrs.cpp
@@ +79,2 @@
>      TestMultiMgrsLeftChild* leftie =
> +        static_cast<TestMultiMgrsLeftChild*>(leftIter.Get()->GetKey());

You may be able to use LoneManageeOrNull from ProtocolUtils.h here, which makes things slightly less ugly.

@@ +83,2 @@
>      TestMultiMgrsRightChild* rightie =
> +        static_cast<TestMultiMgrsRightChild*>(rightIter.Get()->GetKey());

Here too.
Attachment #8677175 - Flags: review?(nfroyd) → review+
Attached patch Fixes (r2)Splinter Review
Changes made as requested. Carrying forward r+.
Attachment #8677175 - Attachment is obsolete: true
Attachment #8677634 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2353ad287e4d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.