Closed
Bug 1217250
Opened 9 years ago
Closed 9 years ago
Some IPDL C++ regression tests are busted
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
2.60 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
Looks like some Length() -> Count() conversions were missed.
Assignee | ||
Comment 1•9 years ago
|
||
TestMultiMgrs.cpp
TestManyChildAllocs.cpp
Assignee | ||
Comment 2•9 years ago
|
||
![]() |
||
Comment 3•9 years ago
|
||
Comment on attachment 8677175 [details] [diff] [review]
Fixes
Review of attachment 8677175 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for fixing this!
r=me with the changes below if you can use ProtocolUtils.h in this code, otherwise r=me as is.
::: ipc/ipdl/test/cxx/TestMultiMgrs.cpp
@@ +79,2 @@
> TestMultiMgrsLeftChild* leftie =
> + static_cast<TestMultiMgrsLeftChild*>(leftIter.Get()->GetKey());
You may be able to use LoneManageeOrNull from ProtocolUtils.h here, which makes things slightly less ugly.
@@ +83,2 @@
> TestMultiMgrsRightChild* rightie =
> + static_cast<TestMultiMgrsRightChild*>(rightIter.Get()->GetKey());
Here too.
Attachment #8677175 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Changes made as requested. Carrying forward r+.
Attachment #8677175 -
Attachment is obsolete: true
Attachment #8677634 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•