1217250 - Some IPDL C++ regression tests are busted

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Looks like some Length() -> Count() conversions were missed.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

TestMultiMgrs.cpp
TestManyChildAllocs.cpp

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fixes

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8677175 [details] [diff] [review]
Fixes

Review of attachment 8677175 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

r=me with the changes below if you can use ProtocolUtils.h in this code, otherwise r=me as is.

::: ipc/ipdl/test/cxx/TestMultiMgrs.cpp
@@ +79,2 @@
>      TestMultiMgrsLeftChild* leftie =
> +        static_cast<TestMultiMgrsLeftChild*>(leftIter.Get()->GetKey());

You may be able to use LoneManageeOrNull from ProtocolUtils.h here, which makes things slightly less ugly.

@@ +83,2 @@
>      TestMultiMgrsRightChild* rightie =
> +        static_cast<TestMultiMgrsRightChild*>(rightIter.Get()->GetKey());

Here too.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fixes (r2)

Changes made as requested. Carrying forward r+.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2353ad287e4d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2353ad287e4d