Closed Bug 1217335 Opened 4 years ago Closed 4 years ago

Context is no longer shown on loading the standalone window

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox44 verified)

VERIFIED FIXED
mozilla44
Iteration:
44.3 - Nov 2
Tracking Status
firefox44 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression from bug 1208201 - not shipped in production yet.

The context is no longer shown in the text area of the standalone display when loading a room.

Bug 1208201 merged a couple of actions, but didn't update all locations properly. Desktop gets away with this as there's an extra update cycle that happens (and uses the right attribute).
This makes the necessary adjustments. I've gone with roomContextUrls in more places as that's more descriptive than just "urls" (althought he room information we get from the server is just "urls" which is why we have that in some places.
Attachment #8677394 - Flags: review?(edilee)
Comment on attachment 8677394 [details] [diff] [review]
Room context is no longer shown when loading the Loop standalone UI.

ui-showcase has an UpdateRoomInfo passing in a "urls":

https://dxr.mozilla.org/mozilla-central/source/browser/components/loop/ui/ui-showcase.jsx#332
Attachment #8677394 - Flags: review?(edilee) → review+
https://hg.mozilla.org/mozilla-central/rev/045a0eb88d6a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Iteration: --- → 44.3 - Nov 2
We did some exploratory testing on Hello using Firefox 44 beta 2 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 64-bit) and can confirm that context showed up in Standalone each time.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.