Closed
Bug 1217336
Opened 9 years ago
Closed 9 years ago
[gaia_sim_picker] in RTL, sims are left aligned until the component receive a 'localized' event.
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: autra, Assigned: autra)
References
Details
Attachments
(1 file)
We rely on the localized event to indicate to the gaia-menu inside the gaia-sim-picker its direction. But when adding the element dynamically, there's no such event, so gaia-menu still thinks it is LTR. The element must be initialized with the proper direction as soon as added.
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8677528 [details] [review] [gaia] Phoxygen:bug1217336-gaia_sim_picker_init > mozilla-b2g:master Hi Kevin, please R?
Attachment #8677528 -
Flags: review?(kevingrandon)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8677528 [details] [review] [gaia] Phoxygen:bug1217336-gaia_sim_picker_init > mozilla-b2g:master Seems fine to me, thanks!
Attachment #8677528 -
Flags: review?(kevingrandon) → review+
|
|
||
Comment 4•9 years ago
|
||
In master: https://github.com/mozilla-b2g/gaia/commit/e252fe216270f04f72319f3f5163b407e12f0426
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•