121735 - Perl warning running checksetup.pl if a module has a non-numeric version number

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Dave Miller [:justdave]]

Checking perl modules ...
Checking for             DBI (v1.13)   ok: found v1.14
Checking for    Data::Dumper (any)     ok: found v2.101
Checking for      DBD::mysql (v1.2209) ok: found v2.0415
Checking for     Date::Parse (any)     ok: found v2.20
Checking for       AppConfig (v1.52)   ok: found v1.52
Checking for        Template (v2.06)   Argument "2.06d" isn't numeric in numeric
lt (<) at ./checksetup.pl line 170 (#1)
    
    (W numeric) The indicated string was fed as an argument to an operator that
    expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
    
ok: found v2.06d
Checking for      Text::Wrap (v2001.0131) ok: found v2001.0929
Checking for       CGI::Carp (any)     ok: found v1.20

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch

Use vers_cmp() instead of a numeric ">"

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch v2

bbaetz pointed out that if a module was misreporting its version (such as the
current Chart::Base) that it was showing up as "not found" instead of "unknown
version".  This should fix that.

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 66395 [details] [diff] [review]
Patch v2

r=bbaetz

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 66395 [details] [diff] [review]
Patch v2

r=gerv (although we should put space between function arguments.) Looks good
otherwise.

Gerv

Comment 5

[Zach Lipton [:zach]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.114; previous revision: 1.113
done