Perl warning running checksetup.pl if a module has a non-numeric version number

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Installation & Upgrading
P1
blocker
RESOLVED FIXED
17 years ago
5 years ago

People

(Reporter: justdave, Assigned: zach)

Tracking

2.15
Bugzilla 2.16

Details

Attachments

(1 attachment, 1 obsolete attachment)

Checking perl modules ...
Checking for             DBI (v1.13)   ok: found v1.14
Checking for    Data::Dumper (any)     ok: found v2.101
Checking for      DBD::mysql (v1.2209) ok: found v2.0415
Checking for     Date::Parse (any)     ok: found v2.20
Checking for       AppConfig (v1.52)   ok: found v1.52
Checking for        Template (v2.06)   Argument "2.06d" isn't numeric in numeric
lt (<) at ./checksetup.pl line 170 (#1)
    
    (W numeric) The indicated string was fed as an argument to an operator that
    expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
    
ok: found v2.06d
Checking for      Text::Wrap (v2001.0131) ok: found v2001.0929
Checking for       CGI::Carp (any)     ok: found v1.20
Created attachment 66391 [details] [diff] [review]
Patch

Use vers_cmp() instead of a numeric ">"
Severity: normal → blocker
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Created attachment 66395 [details] [diff] [review]
Patch v2

bbaetz pointed out that if a module was misreporting its version (such as the
current Chart::Base) that it was showing up as "not found" instead of "unknown
version".  This should fix that.
Attachment #66391 - Attachment is obsolete: true
Comment on attachment 66395 [details] [diff] [review]
Patch v2

r=bbaetz
Attachment #66395 - Flags: review+
Keywords: patch, review
Comment on attachment 66395 [details] [diff] [review]
Patch v2

r=gerv (although we should put space between function arguments.) Looks good
otherwise.

Gerv
Attachment #66395 - Flags: review+
(Assignee)

Comment 5

17 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.114; previous revision: 1.113
done
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.