1217357 - Update broken call to getContentWindow() from larch merge

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://hg.mozilla.org/mozilla-central/annotate/f029ccdee154bdc2b49a1e0fcd5b0fa0397aa97b/b2g/chrome/content/shell.js#l108 

bug 1160923 removed getContentWindow() but bug 1204965 merged some code containing that. It should be updated to either

shell.contentBrowser.contentWindow

or 

SystemAppProxy._frame.contentWindow

Apparently the branch does not contain any test to realize this feature is broken? I can help with a drive-by patch tomorrow or someone can beat me to it.

PS I really don't like these untested global functions being checked into shell.js. Not sure who can make the call here and if the said person really cares.

Comment 1

[Kevin Grandon :kgrandon]

Thanks for filing, sorry about merging this in a broken state - it should definitely have tests. I can't get to this immediately

Comment 2

[Kevin Grandon :kgrandon]

Oops, accidentally submitted the form, was going to say:

Thanks for filing, sorry about merging this in a broken state - it should definitely have tests. I can't get to this immediately but may be able to take it down the road if you don't get to it.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1217357.patch

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8677848 [details] [diff] [review]
bug1217357.patch

Review of attachment 8677848 [details] [diff] [review]:
-----------------------------------------------------------------

Not too familiar with this stuff, but this particular getter seems to be all over shell.js so it makes sense to me. Thank you very much for fixing it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3b5812d1023c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b5812d1023c