1217362 - nsIHttpChannelInternal::getRemoteAddress() doesn't work in content processes

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Roxana Ilie]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.7 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.7

Steps to reproduce:

I tried to get server IP address when I was using Navigator::SendBeacon(), after the channel was opened and all the informations should be available in BeaconStreamListener::OnStartRequest().


Actual results:

I was receiving ns_error_not_available, because nsIHttpChannelInternal object was calling HttpChannelChild::GetRemoteAddress()


Expected results:

nsIHttpChannelInternal object should have called HttpBaseChannel::GetRemoteAddress(), and servers IP address should be available.

Comment 1

[Patrick McManus [:mcmanus]]

in general a lot of networking code is on the parent process only, but this particular method does get used by some child code (beacon is noted here) so should be e10s enabled.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Jason, can we get an assignee?

Comment 3

[Jason Duell]

This is probably a dupe of bug 664163.  I'll find someone to fix.

Comment 4

[Jim Mathies [:jimm]]

triage note: bug 664163 has patches, waiting on that to land then we'll retest this.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Tracy, but 664163 was resolved 2 months ago, can you confirm that this is fixed and dupe it over or renom?

Comment 6

[Tracy Walker [:tracy]]

Roxana, can you provide a testcase and/or verify this is fixed from the noted bug above?

Comment 7

[Roxana Ilie]

I tested it and now everything is ok.

The idea is that because HttpChannelChild::GetRemoteAddress() has been deleted in the patch for 664163, now HttpBaseChannel::GetRemoteAddress is always called.

Comment 8

[Tracy Walker [:tracy]]

Thank you Roxana.