1217369 - "Welcome to ..." has extra padding on the standalone UI making it feel strange

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Attachment: Screen shot of issue (left: before, right: after regression)

Bug 1204345 changed some of the padding/margins around the elements in the standalone UI.

It isn't clear from that bug that the change in padding/margins for the room name was intentional, and to me it feels strange to have the extra vertical padding - see the attached screenshot.

Comment 1

[Mark Banner (:standard8)]

Attachment: Screen shot (left: before regression, right: after plus patch)

Sevaan: This reverts us to what we were before the change. There's a little bit of height difference overall as a end result, but I think it looks a lot better than the regressed version, and I'm not sure the slight padding changes really matter.

Comment 2

[Mark Banner (:standard8)]

Attachment: "Welcome to ..." has extra padding on Loop's standalone UI making it feel strange.

This fixes the extra margins issue - <p> comes with its own margins, and we just need to nuke them here (they were previously nuked, but the classes were changed, and the side-effects weren't checked).

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/85bd262e7094

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/85bd262e7094

Comment 5

[Bogdan Maris, Desktop QA]

Verified that the initial issue is fixed across platforms (Windows 10 64-bit, Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit) using latest Developer Edition 44.0a2.