Closed
Bug 1217385
Opened 9 years ago
Closed 9 years ago
Write tests for BrowserDialog deferred actions
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [partner-cherry-pick][ft:conndevices])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
Bug 1217376 introduced deferred actions to BrowserDialog, we need some tests for that.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Priority: -- → P3
Target Milestone: --- → FxOS-S10 (30Oct)
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: FxOS-S10 (30Oct) → FxOS-S11 (13Nov)
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8684973 -
Flags: review?(yliao)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8684973 [details] [review] [gaia] ferjm:bug1217385.browserdialog.tests > mozilla-b2g:master Thank you!
Attachment #8684973 -
Flags: review?(yliao) → review+
|
||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/7daec3853ca863b3b4a08bb01a1c8738e23d10c9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8684973 [details] [review] [gaia] ferjm:bug1217385.browserdialog.tests > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1194108 [User impact] if declined: no test for BrowserDialog [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=da63680529e835f69fbef7707b34375740eb9ab6 [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8684973 -
Flags: approval-gaia-v2.5?
|
||
Updated•9 years ago
|
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8684973 [details] [review] [gaia] ferjm:bug1217385.browserdialog.tests > mozilla-b2g:master Approve as this is required BrowserDialog
Attachment #8684973 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
|
||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick] → [partner-cherry-pick][ft:conndevices]
|
||
Comment 6•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/a2b74bf1112d2788824e6e79c642a3bcaa063bbf
You need to log in
before you can comment on or make changes to this bug.
Description
•