1217393 - The hold button is hidden when the last call is hung up

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

The changes in bug 1162732 have introduced an unwanted issue with the hold button. When the last call is ended there's no call that can be held or merged and thus the container of the hold/merge button is hidden. This is jarring as just after tapping the end call button the buttons above switch from 5 to 4 without an apparent reason.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1217393-hidden-hold-button-fix > mozilla-b2g:master

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8677446 [details] [review]
[gaia] gabrielesvelto:bug-1217393-hidden-hold-button-fix > mozilla-b2g:master

Quick fix for this annoying glitch that happens when we hang up the last call.

Comment 3

[Tamara Hills [:thills]]

Comment on attachment 8677446 [details] [review]
[gaia] gabrielesvelto:bug-1217393-hidden-hold-button-fix > mozilla-b2g:master

Hi Gabriele,

r+ for the Callscreen piece.  It looks good.  Do you think you can have a keyboard peer review the keyboard files?  I'm not a peer there.

Thanks,

-tamara

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Tamara Hills [:thills] from comment #3)
> r+ for the Callscreen piece.  It looks good.  Do you think you can have a
> keyboard peer review the keyboard files?  I'm not a peer there.

You just made me realize that I must have committed my changes into somebody's else patch. There shouldn't have been any keyboard changes in my patch :-P

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Yes, I had "amended" a previous patch with my changes. I've pushed again to the PR and removed the spurious stuff, thanks for the review.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Merged to gaia/master eccb45e48f6256e658717a2e91059695ecf3cfcb

https://github.com/mozilla-b2g/gaia/commit/eccb45e48f6256e658717a2e91059695ecf3cfcb