121741 - using quicksearch while bugzilla is shut down for backup gets "can't use xxx as a field name" error

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P1)

Description

[Dave Miller [:justdave]]

If you visit http://bugzilla.mozilla.org/ and enter something in the quicksearch
box and submit it while Bugzilla is down for it's nightly backup, you get the
following error:

Can't use short_desc as a field name. If you think you're getting this in error,
please copy the entire URL out of the address bar at the top of your browser
window and email it to <[e-mail]>                                       

Replace "short_desc" with the field of your choice, it varies depending on what
you put in the quicksearch box.

This situation should cause the value of shutdownhtml to be displayed instead. 
This means buglist.cgi is actually processing the form before it checks for
shutdownhtml, which is a bad thing. :)

Comment 1

[Dave Miller [:justdave]]

Myk: I will respectfully request that once this is fixed, you apply the patch on
b.m.o if you're not prepared to update yet at that point.  I'm getting 3 to 4
emails every night from people following the directions in the error message. :)

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 66406 [details] [diff] [review]
Patch

Needs a 
print "Content-type: text/html\n\n"; 
within the code block.

Comment 4

[Dave Miller [:justdave]]

I thought PutHeader() did that for you?  Mozilla displays it. :)

Comment 5

[Dave Miller [:justdave]]

Attachment: Patch v2

hmm, guess it doesn't.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 66412 [details] [diff] [review]
Patch v2

Works as expected.
r=dkl

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch v3

Additional changes based on comments from bbaetz in IRC.

Comment 8

[Bradley Baetz (:bbaetz)]

Actually, see bug 121747. I think we need a global routine for this, if we don't
just wrap it up into ConnectToDatabase()

Comment 9

[Gervase Markham [:gerv]]

This is a band-aid, right? When we have index.cgi, you won't be able to access
Quick Search when Bugzilla is down.

Gerv

Comment 10

[Dave Miller [:justdave]]

You won't be able to access quicksearch, but you'll still be able to load
buglist.cgi directly, and it's actually buglist.cgi that has the problem, not
quicksearch.

I duplicated it on a local install by doing this:

1) Load query.cgi, put in some arbitrary query, don't hit submit yet.
2) Open a new window and go into editparams.cgi
3) enter something in shutdownhtml and submit.
4) go back to your query.cgi window and hit the submit button
5) you get the above-mentioned error message.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

I've got a solution for this that works across all CGIs in bug 121747.

Comment 12

[Dave Miller [:justdave]]

The patch checked in from bug 121747 has fixed this.