Closed Bug 1217418 Opened 5 years ago Closed 5 years ago

Make wpt update script more robust in the face of patches that won't apply.

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: jgraham, Unassigned)

Details

Attachments

(1 file)

wpt-update.diff
2.32 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
Attached patch wpt-update.diff — — Splinter Review 
No description provided.
Attachment #8677466 - Flags: review?(Ms2ger)
Comment on attachment 8677466 [details] [diff] [review]
wpt-update.diff

Review of attachment 8677466 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8677466 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/f65121860ffe
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/28db7cfb2e4a because https://hg.mozilla.org/integration/mozilla-inbound/rev/af7f10137637#l14.8 made Linux x64 debug W-e10s(3) permafail and this patch landed between the two patches of bug 1217767 which caused the failure.
WTF Why did this get backed out when it a) had nothing to do with the permafail and b) when the permafail was clearly incorrect metadata that should just have been fixed. Given it was backed out, why didn't the bug get reopened?
Flags: needinfo?(aryx.bugmail)
(In reply to James Graham [:jgraham] from comment #6)
> WTF Why did this get backed out when it a) had nothing to do with the permafail
That wasn't obvious to two sheriffs because this checkin had been sandwiched between the two for bug 1217767 which are two pulled updates for which the second one needed an update to this script. There wasn't any information in this bug and if it affected the other one, so it also got backed out.

> b) when the permafail was clearly incorrect metadata that should just have been fixed.
Whoever would have fixed it would also have needed review (on a Saturday).

> Given it was backed out, why didn't the bug get reopened?
Sorry, that was my mistake. I hadn't noticed that it had already been merged to the other integration branches.
Flags: needinfo?(aryx.bugmail)
(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #8)
> (In reply to James Graham [:jgraham] from comment #6)
> > WTF Why did this get backed out when it a) had nothing to do with the permafail
> That wasn't obvious to two sheriffs because this checkin had been sandwiched
> between the two for bug 1217767 which are two pulled updates for which the
> second one needed an update to this script. There wasn't any information in
> this bug and if it affected the other one, so it also got backed out.
> 
> > b) when the permafail was clearly incorrect metadata that should just have been fixed.
> Whoever would have fixed it would also have needed review (on a Saturday).

Trivial bustages fixes don't need review in general.

Sorry to go on about this, but the fact that two weeks have passed since this backout has created a real mess that I need to fix when trying to do the next wpt update.
You need to log in before you can comment on or make changes to this bug.