Closed Bug 1217484 Opened 4 years ago Closed 4 years ago

Intermittent testNewTab | GeckoEventExpecter - blockForEvent timeout: Content:PageShow

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: KWierso, Assigned: mcomella)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

It seems we fail here:
  22:00:51     INFO -  TEST-PASS | testNewTab | URL typed properly - http://mochi.test:8888/tests/robocop/robocop_blank_01.html should equal http://mochi.test:8888/tests/robocop/robocop_blank_01.html
  22:00:51     INFO -  TEST-PASS | testNewTab | Given message occurred for registered event: {"bgColor":"transparent","errorType":"","type":"DOMContentLoaded","metadata":null,"tabID":1} - DOMContentLoaded should equal DOMContentLoaded
  22:00:51     INFO -  EventExpecter: no longer listening for DOMContentLoaded
  22:00:51     INFO -  TEST-PASS | testNewTab | Number of tabs increased - 2 should equal 2
  22:00:51     INFO -  TEST-PASS | testNewTab | waiting for add tab view - add tab view available

And here:
  15:03:44     INFO -  TEST-PASS | testNewTab | Initial number of tabs correct - 1 should equal 1
  15:03:44     INFO -  TEST-PASS | testNewTab | waiting for add tab view - add tab view available
  15:03:44     INFO -  TEST-PASS | testNewTab | Given message occurred for registered event: {"type":"Content:PageShow","userRequested":"","tabID":0} - Content:PageShow should equal Content:PageShow
  15:03:44     INFO -  addTab ignoring PageShow for tab 0

I wonder if the issue here is that we don't wait for the animations to finish before trying press buttons and this is dropping our presses and putting us into a weird state (e.g. race conditions).
Or perhaps we're finding and trying to click the view when it's animating (causing us to miss or we disable clicks when it's animating to prevent weird state). The animation probably occurs in hardware layers so maybe the view is off-screen at this point as well.
Bug 1217484 - Wait for animations to finish in testNewTab. r=sebastian

By waiting an arbitrary amount of time. :(
comment 10 has my shot in the dark on trying to fix this by waiting for animations to fix this.

For context, I'm having similar failures for bug 1209967 so I'm trying to work it out here.
The patch in comment 12 seems to have worked though I waited before pressing buttons rather than after so it's entirely correct. I'm going to reorder the content, push another try to double-check, and flag for review.
Assignee: nobody → michael.l.comella
Comment on attachment 8694447 [details]
MozReview Request: Bug 1217484 - Wait for animations to finish in testNewTab. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26745/diff/1-2/
Attachment #8694447 - Flags: review?(s.kaspari)
Comment on attachment 8694447 [details]
MozReview Request: Bug 1217484 - Wait for animations to finish in testNewTab. r=sebastian

https://reviewboard.mozilla.org/r/26745/#review24439
Attachment #8694447 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/536efefba224
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
All of the failures from comment 19 occurred on 12/3 so this patch looks like it worked.
You need to log in before you can comment on or make changes to this bug.