1217500 - Add UI for inverting display tree in memory tool

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: WIP (haven't finished tests): Add UI for inverting display tree in memory tool

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add UI for inverting display tree in memory tool

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=30864db5c025

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8678985 [details] [diff] [review]
Add UI for inverting display tree in memory tool

Review of attachment 8678985 [details] [diff] [review]:
-----------------------------------------------------------------

nit

::: devtools/client/memory/actions/snapshot.js
@@ +104,5 @@
>        breakdown = getState().breakdown;
> +      dispatch({ type: actions.TAKE_CENSUS_START, snapshot, inverted, breakdown });
> +      let opts = inverted ? { asInvertedTreeNode: true } : { asTreeNode: true };
> +      census = yield heapWorker.takeCensus(snapshot.path, { breakdown }, opts);
> +    } while (inverted !== getState().inverted ||

put the while on a new line since it got huge

do {
...
}
while (...||
       ...);

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e3b623fd16bf

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/3af8b8e56340 since I didn't know whether it was this or bug 1218560 leaking like https://treeherder.mozilla.org/logviewer.html#?job_id=5354136&repo=fx-team

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Figuring out which patch triggered the leaks.

Try push with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=970abc321d0f

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/964ecb2b68a0

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/964ecb2b68a0