Closed Bug 1217500 Opened 4 years ago Closed 4 years ago

Add UI for inverting display tree in memory tool

Categories

(DevTools :: Memory, defect)

43 Branch
defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: jsantell, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8678381 - Attachment is obsolete: true
Comment on attachment 8678985 [details] [diff] [review]
Add UI for inverting display tree in memory tool

Review of attachment 8678985 [details] [diff] [review]:
-----------------------------------------------------------------

nit

::: devtools/client/memory/actions/snapshot.js
@@ +104,5 @@
>        breakdown = getState().breakdown;
> +      dispatch({ type: actions.TAKE_CENSUS_START, snapshot, inverted, breakdown });
> +      let opts = inverted ? { asInvertedTreeNode: true } : { asTreeNode: true };
> +      census = yield heapWorker.takeCensus(snapshot.path, { breakdown }, opts);
> +    } while (inverted !== getState().inverted ||

put the while on a new line since it got huge

do {
...
}
while (...||
       ...);
Attachment #8678985 - Flags: review?(jsantell) → review+
Figuring out which patch triggered the leaks.

Try push with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=970abc321d0f
https://hg.mozilla.org/mozilla-central/rev/964ecb2b68a0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.