Closed
Bug 1217520
Opened 10 years ago
Closed 9 years ago
Improve speed of import_perf_data script using bulk_create
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: vakila, Mentored)
Details
(Whiteboard: perfherder-starter-bug)
User Story
Thank you for helping out with Treeherder! You can find us on IRC at irc://irc.mozilla.org/treeherder Here's some links to help get you started. Project page: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder Interacting with us, repo locations and links to set up a development version of the software: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs A-Team general reference, coding style guides: https://ateam-bootcamp.readthedocs.org
Attachments
(1 file)
We have a command in perfherder for importing performance data from an existing instance of treeherder/perfherder. The import_perf_data script in perfherder's speed could be improved if we inserted the performance datum objects in bulk.
You can see an example of where we used to do this here in a deprecated migration script:
https://github.com/mozilla/treeherder/blob/066f437ca52b8833b5178eb68a7f2d2480f97574/treeherder/perf/management/commands/migrate_perf_data.py#L92
The file you want to modify is `treeherder/perf/management/commands/import_perf_data.py`. Specifically around here:
https://github.com/mozilla/treeherder/blob/master/treeherder/perf/management/commands/import_perf_data.py#L66
To test your change, set up a development instance of treeherder per the user story, then from vagrant ssh, run:
./manage.py import_reference_data # required to view performance data
./manage.py import_perf_data --interval 2592000 --filter-props suite:tcheck2 mozilla-central
|
Reporter | |
Comment 1•10 years ago
|
||
I'd like to mentor this bug. If you're not new to treeherder/perfherder, please don't take this. :) It's meant to be a simple launching off point to doing further treeherder development.
Mentor: wlachance
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: perfherder-starter-bug
|
||
Comment 2•9 years ago
|
||
Assignee: nobody → anjanavakil
|
Assignee | |
Updated•9 years ago
|
Attachment #8731799 -
Flags: review?(wlachance)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8731799 [details] [review]
[treeherder] vakila:perf-data-bulk > mozilla:master
Looks great now, thanks!
Attachment #8731799 -
Flags: review?(wlachance) → review+
|
|
||
Comment 4•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/39d51cad8feba943a9c5431629930e8ba0c021a1
|
||
Comment 5•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/5d4b27a18c9bf640f4d3233e55f02b2970f637f2
Bug 1217520 - Import perf data using bulk_create if possible
https://github.com/mozilla/treeherder/commit/5fd55233d3e60bc19d9fd8acac7b154ece9efa8b
Bug 1217520 - Remove check for null signature.last_updated
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•