[driver] set browser.tabs.remote.autostart to False in GeckoInstance.required_prefs

RESOLVED FIXED in Firefox 45

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There's an --e10s option available in the Marionette Python client. I think '--e10s' should mean 'use e10s' and the absence of the flag should mean 'don't use e10s', even after e10s ships someday on the Release channel. [1] 

That's not the case right now. When the --e10s flag is absent, only "browser.tabs.remote.autostart.1" and "browser.tabs.remote.autostart.2" are set to False (marionette-driver/geckoinstance.py). If the default value of "browser.tabs.remote.autostart" changes in the future, the behaviour of many test jobs will silently change with it.

[1] firefox-ui-tests enforce this definition - https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_harness/runners/base.py#L67-L68.
Totally agree here. That was the main reason afair to customize that initially in our Firefox UI tests.
Blocks: 1212608
(Assignee)

Comment 2

2 years ago
Created attachment 8682228 [details]
MozReview Request: Bug 1217557 - set browser.tabs.remote.autostart to False in GeckoInstance; r?automatedtester

Bug 1217557 - set browser.tabs.remote.autostart to False in GeckoInstance; r?automatedtester
Attachment #8682228 - Flags: review?(dburns)
(Assignee)

Updated

2 years ago
Assignee: nobody → mjzffr
Status: NEW → ASSIGNED
Comment on attachment 8682228 [details]
MozReview Request: Bug 1217557 - set browser.tabs.remote.autostart to False in GeckoInstance; r?automatedtester

https://reviewboard.mozilla.org/r/24001/#review21477
Attachment #8682228 - Flags: review?(dburns) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4827bf333fe8

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/70df5b203edb
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70df5b203edb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.