Closed Bug 1217557 Opened 6 years ago Closed 6 years ago

[driver] set browser.tabs.remote.autostart to False in GeckoInstance.required_prefs

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: impossibus, Assigned: impossibus)

References

Details

Attachments

(1 file)

There's an --e10s option available in the Marionette Python client. I think '--e10s' should mean 'use e10s' and the absence of the flag should mean 'don't use e10s', even after e10s ships someday on the Release channel. [1] 

That's not the case right now. When the --e10s flag is absent, only "browser.tabs.remote.autostart.1" and "browser.tabs.remote.autostart.2" are set to False (marionette-driver/geckoinstance.py). If the default value of "browser.tabs.remote.autostart" changes in the future, the behaviour of many test jobs will silently change with it.

[1] firefox-ui-tests enforce this definition - https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_harness/runners/base.py#L67-L68.
Totally agree here. That was the main reason afair to customize that initially in our Firefox UI tests.
Blocks: 1212608
Bug 1217557 - set browser.tabs.remote.autostart to False in GeckoInstance; r?automatedtester
Attachment #8682228 - Flags: review?(dburns)
Assignee: nobody → mjzffr
Status: NEW → ASSIGNED
Comment on attachment 8682228 [details]
MozReview Request: Bug 1217557 - set browser.tabs.remote.autostart to False in GeckoInstance; r?automatedtester

https://reviewboard.mozilla.org/r/24001/#review21477
Attachment #8682228 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/70df5b203edb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.